Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Side by Side Diff: gin/handle.h

Issue 1112923003: Replace Handle<> with Local in remaining gin/* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « gin/function_template.cc ('k') | gin/interceptor_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef GIN_HANDLE_H_ 5 #ifndef GIN_HANDLE_H_
6 #define GIN_HANDLE_H_ 6 #define GIN_HANDLE_H_
7 7
8 #include "gin/converter.h" 8 #include "gin/converter.h"
9 9
10 namespace gin { 10 namespace gin {
11 11
12 // You can use gin::Handle on the stack to retain a gin::Wrappable object. 12 // You can use gin::Handle on the stack to retain a gin::Wrappable object.
13 // Currently we don't have a mechanism for retaining a gin::Wrappable object 13 // Currently we don't have a mechanism for retaining a gin::Wrappable object
14 // in the C++ heap because strong references from C++ to V8 can cause memory 14 // in the C++ heap because strong references from C++ to V8 can cause memory
15 // leaks. 15 // leaks.
16 template<typename T> 16 template<typename T>
17 class Handle { 17 class Handle {
18 public: 18 public:
19 Handle() : object_(NULL) {} 19 Handle() : object_(NULL) {}
20 20
21 Handle(v8::Handle<v8::Value> wrapper, T* object) 21 Handle(v8::Local<v8::Value> wrapper, T* object)
22 : wrapper_(wrapper), 22 : wrapper_(wrapper),
23 object_(object) { 23 object_(object) {
24 } 24 }
25 25
26 bool IsEmpty() const { return !object_; } 26 bool IsEmpty() const { return !object_; }
27 27
28 void Clear() { 28 void Clear() {
29 wrapper_.Clear(); 29 wrapper_.Clear();
30 object_ = NULL; 30 object_ = NULL;
31 } 31 }
32 32
33 T* operator->() const { return object_; } 33 T* operator->() const { return object_; }
34 v8::Handle<v8::Value> ToV8() const { return wrapper_; } 34 v8::Local<v8::Value> ToV8() const { return wrapper_; }
35 T* get() const { return object_; } 35 T* get() const { return object_; }
36 36
37 private: 37 private:
38 v8::Handle<v8::Value> wrapper_; 38 v8::Local<v8::Value> wrapper_;
39 T* object_; 39 T* object_;
40 }; 40 };
41 41
42 template<typename T> 42 template<typename T>
43 struct Converter<gin::Handle<T> > { 43 struct Converter<gin::Handle<T> > {
44 static v8::Handle<v8::Value> ToV8(v8::Isolate* isolate, 44 static v8::Local<v8::Value> ToV8(v8::Isolate* isolate,
45 const gin::Handle<T>& val) { 45 const gin::Handle<T>& val) {
46 return val.ToV8(); 46 return val.ToV8();
47 } 47 }
48 static bool FromV8(v8::Isolate* isolate, v8::Handle<v8::Value> val, 48 static bool FromV8(v8::Isolate* isolate, v8::Local<v8::Value> val,
49 gin::Handle<T>* out) { 49 gin::Handle<T>* out) {
50 T* object = NULL; 50 T* object = NULL;
51 if (!Converter<T*>::FromV8(isolate, val, &object)) { 51 if (!Converter<T*>::FromV8(isolate, val, &object)) {
52 return false; 52 return false;
53 } 53 }
54 *out = gin::Handle<T>(val, object); 54 *out = gin::Handle<T>(val, object);
55 return true; 55 return true;
56 } 56 }
57 }; 57 };
58 58
59 // This function is a convenient way to create a handle from a raw pointer 59 // This function is a convenient way to create a handle from a raw pointer
60 // without having to write out the type of the object explicitly. 60 // without having to write out the type of the object explicitly.
61 template<typename T> 61 template<typename T>
62 gin::Handle<T> CreateHandle(v8::Isolate* isolate, T* object) { 62 gin::Handle<T> CreateHandle(v8::Isolate* isolate, T* object) {
63 v8::Handle<v8::Object> wrapper = object->GetWrapper(isolate); 63 v8::Local<v8::Object> wrapper = object->GetWrapper(isolate);
64 if (wrapper.IsEmpty()) 64 if (wrapper.IsEmpty())
65 return gin::Handle<T>(); 65 return gin::Handle<T>();
66 return gin::Handle<T>(wrapper, object); 66 return gin::Handle<T>(wrapper, object);
67 } 67 }
68 68
69 } // namespace gin 69 } // namespace gin
70 70
71 #endif // GIN_HANDLE_H_ 71 #endif // GIN_HANDLE_H_
OLDNEW
« no previous file with comments | « gin/function_template.cc ('k') | gin/interceptor_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698