Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Side by Side Diff: gin/arguments.h

Issue 1112923003: Replace Handle<> with Local in remaining gin/* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | gin/arguments.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef GIN_ARGUMENTS_H_ 5 #ifndef GIN_ARGUMENTS_H_
6 #define GIN_ARGUMENTS_H_ 6 #define GIN_ARGUMENTS_H_
7 7
8 #include "base/basictypes.h" 8 #include "base/basictypes.h"
9 #include "gin/converter.h" 9 #include "gin/converter.h"
10 #include "gin/gin_export.h" 10 #include "gin/gin_export.h"
(...skipping 18 matching lines...) Expand all
29 bool GetData(T* out) { 29 bool GetData(T* out) {
30 return ConvertFromV8(isolate_, info_->Data(), out); 30 return ConvertFromV8(isolate_, info_->Data(), out);
31 } 31 }
32 32
33 template<typename T> 33 template<typename T>
34 bool GetNext(T* out) { 34 bool GetNext(T* out) {
35 if (next_ >= info_->Length()) { 35 if (next_ >= info_->Length()) {
36 insufficient_arguments_ = true; 36 insufficient_arguments_ = true;
37 return false; 37 return false;
38 } 38 }
39 v8::Handle<v8::Value> val = (*info_)[next_++]; 39 v8::Local<v8::Value> val = (*info_)[next_++];
40 return ConvertFromV8(isolate_, val, out); 40 return ConvertFromV8(isolate_, val, out);
41 } 41 }
42 42
43 template<typename T> 43 template<typename T>
44 bool GetRemaining(std::vector<T>* out) { 44 bool GetRemaining(std::vector<T>* out) {
45 if (next_ >= info_->Length()) { 45 if (next_ >= info_->Length()) {
46 insufficient_arguments_ = true; 46 insufficient_arguments_ = true;
47 return false; 47 return false;
48 } 48 }
49 int remaining = info_->Length() - next_; 49 int remaining = info_->Length() - next_;
50 out->resize(remaining); 50 out->resize(remaining);
51 for (int i = 0; i < remaining; ++i) { 51 for (int i = 0; i < remaining; ++i) {
52 v8::Handle<v8::Value> val = (*info_)[next_++]; 52 v8::Local<v8::Value> val = (*info_)[next_++];
53 if (!ConvertFromV8(isolate_, val, &out->at(i))) 53 if (!ConvertFromV8(isolate_, val, &out->at(i)))
54 return false; 54 return false;
55 } 55 }
56 return true; 56 return true;
57 } 57 }
58 58
59 bool Skip() { 59 bool Skip() {
60 if (next_ >= info_->Length()) 60 if (next_ >= info_->Length())
61 return false; 61 return false;
62 next_++; 62 next_++;
63 return true; 63 return true;
64 } 64 }
65 65
66 int Length() const { 66 int Length() const {
67 return info_->Length(); 67 return info_->Length();
68 } 68 }
69 69
70 template<typename T> 70 template<typename T>
71 void Return(T val) { 71 void Return(T val) {
72 info_->GetReturnValue().Set(ConvertToV8(isolate_, val)); 72 info_->GetReturnValue().Set(ConvertToV8(isolate_, val));
73 } 73 }
74 74
75 v8::Handle<v8::Value> PeekNext() const; 75 v8::Local<v8::Value> PeekNext() const;
76 76
77 void ThrowError() const; 77 void ThrowError() const;
78 void ThrowTypeError(const std::string& message) const; 78 void ThrowTypeError(const std::string& message) const;
79 79
80 v8::Isolate* isolate() const { return isolate_; } 80 v8::Isolate* isolate() const { return isolate_; }
81 81
82 // Allows the function handler to distinguish between normal invocation 82 // Allows the function handler to distinguish between normal invocation
83 // and object construction. 83 // and object construction.
84 bool IsConstructCall() const; 84 bool IsConstructCall() const;
85 85
86 private: 86 private:
87 v8::Isolate* isolate_; 87 v8::Isolate* isolate_;
88 const v8::FunctionCallbackInfo<v8::Value>* info_; 88 const v8::FunctionCallbackInfo<v8::Value>* info_;
89 int next_; 89 int next_;
90 bool insufficient_arguments_; 90 bool insufficient_arguments_;
91 }; 91 };
92 92
93 } // namespace gin 93 } // namespace gin
94 94
95 #endif // GIN_ARGUMENTS_H_ 95 #endif // GIN_ARGUMENTS_H_
OLDNEW
« no previous file with comments | « no previous file | gin/arguments.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698