Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Side by Side Diff: gin/function_template.cc

Issue 1112923003: Replace Handle<> with Local in remaining gin/* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « gin/function_template.h ('k') | gin/handle.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "gin/function_template.h" 5 #include "gin/function_template.h"
6 6
7 namespace gin { 7 namespace gin {
8 8
9 namespace internal { 9 namespace internal {
10 10
11 CallbackHolderBase::CallbackHolderBase(v8::Isolate* isolate) 11 CallbackHolderBase::CallbackHolderBase(v8::Isolate* isolate)
12 : v8_ref_(isolate, v8::External::New(isolate, this)) { 12 : v8_ref_(isolate, v8::External::New(isolate, this)) {
13 v8_ref_.SetWeak(this, &CallbackHolderBase::FirstWeakCallback, 13 v8_ref_.SetWeak(this, &CallbackHolderBase::FirstWeakCallback,
14 v8::WeakCallbackType::kParameter); 14 v8::WeakCallbackType::kParameter);
15 } 15 }
16 16
17 CallbackHolderBase::~CallbackHolderBase() { 17 CallbackHolderBase::~CallbackHolderBase() {
18 DCHECK(v8_ref_.IsEmpty()); 18 DCHECK(v8_ref_.IsEmpty());
19 } 19 }
20 20
21 v8::Handle<v8::External> CallbackHolderBase::GetHandle(v8::Isolate* isolate) { 21 v8::Local<v8::External> CallbackHolderBase::GetHandle(v8::Isolate* isolate) {
22 return v8::Local<v8::External>::New(isolate, v8_ref_); 22 return v8::Local<v8::External>::New(isolate, v8_ref_);
23 } 23 }
24 24
25 // static 25 // static
26 void CallbackHolderBase::FirstWeakCallback( 26 void CallbackHolderBase::FirstWeakCallback(
27 const v8::WeakCallbackInfo<CallbackHolderBase>& data) { 27 const v8::WeakCallbackInfo<CallbackHolderBase>& data) {
28 data.GetParameter()->v8_ref_.Reset(); 28 data.GetParameter()->v8_ref_.Reset();
29 data.SetSecondPassCallback(SecondWeakCallback); 29 data.SetSecondPassCallback(SecondWeakCallback);
30 } 30 }
31 31
32 // static 32 // static
33 void CallbackHolderBase::SecondWeakCallback( 33 void CallbackHolderBase::SecondWeakCallback(
34 const v8::WeakCallbackInfo<CallbackHolderBase>& data) { 34 const v8::WeakCallbackInfo<CallbackHolderBase>& data) {
35 delete data.GetParameter(); 35 delete data.GetParameter();
36 } 36 }
37 37
38 } // namespace internal 38 } // namespace internal
39 39
40 } // namespace gin 40 } // namespace gin
OLDNEW
« no previous file with comments | « gin/function_template.h ('k') | gin/handle.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698