Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Unified Diff: gin/function_template.h

Issue 1112923003: Replace Handle<> with Local in remaining gin/* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gin/dictionary.cc ('k') | gin/function_template.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gin/function_template.h
diff --git a/gin/function_template.h b/gin/function_template.h
index 1c8e2bef6bb468171cf17e55f58a2fdca2eb5969..15ea8fef016dbb3ec06eeb4850e4d6077566f615 100644
--- a/gin/function_template.h
+++ b/gin/function_template.h
@@ -44,7 +44,7 @@ struct CallbackParamTraits<const T*> {
// among every CallbackHolder instance.
class GIN_EXPORT CallbackHolderBase {
public:
- v8::Handle<v8::External> GetHandle(v8::Isolate* isolate);
+ v8::Local<v8::External> GetHandle(v8::Isolate* isolate);
protected:
explicit CallbackHolderBase(v8::Isolate* isolate);
@@ -200,7 +200,7 @@ struct Dispatcher<ReturnType(ArgTypes...)> {
static void DispatchToCallback(
const v8::FunctionCallbackInfo<v8::Value>& info) {
Arguments args(info);
- v8::Handle<v8::External> v8_holder;
+ v8::Local<v8::External> v8_holder;
CHECK(args.GetData(&v8_holder));
CallbackHolderBase* holder_base = reinterpret_cast<CallbackHolderBase*>(
v8_holder->Value());
@@ -237,7 +237,7 @@ v8::Local<v8::FunctionTemplate> CreateFunctionTemplate(
return v8::FunctionTemplate::New(
isolate,
&internal::Dispatcher<Sig>::DispatchToCallback,
- ConvertToV8<v8::Handle<v8::External> >(isolate,
+ ConvertToV8<v8::Local<v8::External> >(isolate,
holder->GetHandle(isolate)));
}
@@ -251,7 +251,7 @@ void CreateFunctionHandler(v8::Isolate* isolate,
typedef internal::CallbackHolder<Sig> HolderT;
HolderT* holder = new HolderT(isolate, callback, callback_flags);
tmpl->SetCallAsFunctionHandler(&internal::Dispatcher<Sig>::DispatchToCallback,
- ConvertToV8<v8::Handle<v8::External> >(
+ ConvertToV8<v8::Local<v8::External> >(
isolate, holder->GetHandle(isolate)));
}
« no previous file with comments | « gin/dictionary.cc ('k') | gin/function_template.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698