Simplify the translate infobar code some.

Simplify the translate infobar code some.

The primary change here is to take LanguagesMenuModel, which was used by views, unused by GTK, and only "used" by Cocoa to get the appropriate language names for a menu (which can be done by calling functions on the TranslateInfobarDelegate directly), and make it truly views-specific.

In turn this means we can get rid of the TranslateInfoBarView class, which was only ever used by views even though all platforms included it.  Instead, the SetOriginalLanguage() and SetTargetLanguage() functions on the infobar delegate now become simple setters, and each platform calls Translate() as a followup directly where appropriate.  (This split was necessary because views needed to maintain the current calling order, where the delegate updates the language index, then the infobar updates the button text, then Translate() is called.)

Along the way we also make a number of delegate functions unix_hacker()-style inline getters/setters, and remove some unnecessary "virtual" declarations on functions never overridden.  Finally there are a bunch of other small code simplifications.

BUG=100840
TEST=none
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=157889

[Peter Kasting, 2012-09-19 00:42:02]

Sailesh, if you can patch this in locally and ensure translate infobars still
work correctly on Mac I'd appreciate it -- I'm just a little nervous that the
tests might not find some obvious "nothing happens when you do X" type bug.

https://codereview.chromium.org/10952016/diff/1/chrome/browser/ui/cocoa/infob...
File chrome/browser/ui/cocoa/infobars/translate_infobar_base.mm (right):

https://codereview.chromium.org/10952016/diff/1/chrome/browser/ui/cocoa/infob...
chrome/browser/ui/cocoa/infobars/translate_infobar_base.mm:104: [super
initWithDelegate:delegate owner:owner];
Can we just get rid of this function entirely or something?

[sail, 2012-09-19 02:13:31]

I applied the patch locally and try the translate infobar. Clicking translate
and show original worked fine!

https://codereview.chromium.org/10952016/diff/1/chrome/browser/ui/cocoa/infob...
File chrome/browser/ui/cocoa/infobars/translate_infobar_base.mm (right):

https://codereview.chromium.org/10952016/diff/1/chrome/browser/ui/cocoa/infob...
chrome/browser/ui/cocoa/infobars/translate_infobar_base.mm:104: [super
initWithDelegate:delegate owner:owner];
On 2012/09/19 00:42:02, Peter Kasting wrote:
> Can we just get rid of this function entirely or something?

Yep!

[Peter Kasting, 2012-09-19 02:37:26]

So, is that an R+ then?

(Try changing languages in the menus on both the before- and after-translate
infobars too)

https://codereview.chromium.org/10952016/diff/1/chrome/browser/ui/cocoa/infob...
File chrome/browser/ui/cocoa/infobars/translate_infobar_base.mm (right):

https://codereview.chromium.org/10952016/diff/1/chrome/browser/ui/cocoa/infob...
chrome/browser/ui/cocoa/infobars/translate_infobar_base.mm:104: [super
initWithDelegate:delegate owner:owner];
On 2012/09/19 02:13:31, sail wrote:
> On 2012/09/19 00:42:02, Peter Kasting wrote:
> > Can we just get rid of this function entirely or something?
> 
> Yep!

OK, done.

[sail, 2012-09-19 04:44:05]

cocoa/* LGTM!

https://codereview.chromium.org/10952016/diff/3009/chrome/browser/ui/cocoa/in...
File chrome/browser/ui/cocoa/infobars/translate_infobar_unittest.mm (right):

https://codereview.chromium.org/10952016/diff/3009/chrome/browser/ui/cocoa/in...
chrome/browser/ui/cocoa/infobars/translate_infobar_unittest.mm:62: virtual bool
IsLanguageBlacklisted() { return false; }
should these have OVERRIDE on them?

[Peter Kasting, 2012-09-19 04:53:32]

+sky for views
+erg for GTK and anything cross-platform (not sure of a good reviewer for the
cross-platform stuff)

https://codereview.chromium.org/10952016/diff/3009/chrome/browser/ui/cocoa/in...
File chrome/browser/ui/cocoa/infobars/translate_infobar_unittest.mm (right):

https://codereview.chromium.org/10952016/diff/3009/chrome/browser/ui/cocoa/in...
chrome/browser/ui/cocoa/infobars/translate_infobar_unittest.mm:62: virtual bool
IsLanguageBlacklisted() { return false; }
On 2012/09/19 04:44:06, sail wrote:
> should these have OVERRIDE on them?

Yes.  Good catch.

[sky, 2012-09-19 14:18:06]

LGTM

https://codereview.chromium.org/10952016/diff/3009/chrome/browser/ui/views/in...
File chrome/browser/ui/views/infobars/translate_language_menu_model.h (right):

https://codereview.chromium.org/10952016/diff/3009/chrome/browser/ui/views/in...
chrome/browser/ui/views/infobars/translate_language_menu_model.h:25:
TranslateLanguageMenuModel(LanguageType language_type,
nit: newline between 24/25

https://codereview.chromium.org/10952016/diff/3009/chrome/browser/ui/views/in...
chrome/browser/ui/views/infobars/translate_language_menu_model.h:47: bool
translate_on_change_;
nit: const

[Elliot Glaysher, 2012-09-19 16:38:16]

gtk lgtm