Simplify the translate infobar code some.

chrome/browser/ui/views/infobars/after_translate_infobar.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/infobars/after_translate_infobar.h"
 
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/translate/translate_infobar_delegate.h"
 #include "grit/generated_resources.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/views/controls/button/menu_button.h"
 #include "ui/views/controls/label.h"
 #include "ui/views/controls/menu/menu_item_view.h"
 
 AfterTranslateInfoBar::AfterTranslateInfoBar(
     InfoBarTabHelper* owner,
     TranslateInfoBarDelegate* delegate)
     : TranslateInfoBarBase(owner, delegate),
       label_1_(NULL),
       label_2_(NULL),
       label_3_(NULL),
       original_language_menu_button_(NULL),
       target_language_menu_button_(NULL),
       revert_button_(NULL),
       options_menu_button_(NULL),
-      original_language_menu_model_(delegate, LanguagesMenuModel::ORIGINAL),
-      target_language_menu_model_(delegate, LanguagesMenuModel::TARGET),
       options_menu_model_(delegate),
       swapped_language_buttons_(false) {
 }
 
 AfterTranslateInfoBar::~AfterTranslateInfoBar() {
 }
 
 void AfterTranslateInfoBar::Layout() {
   TranslateInfoBarBase::Layout();
 
@@ skipping 40 matching lines @@
 
 void AfterTranslateInfoBar::ViewHierarchyChanged(bool is_add,
                                                  View* parent,
                                                  View* child) {
   if (!is_add || (child != this) || (label_1_ != NULL)) {
     TranslateInfoBarBase::ViewHierarchyChanged(is_add, parent, child);
     return;
   }
 
   std::vector<string16> strings;
-  GetDelegate()->GetAfterTranslateStrings(&strings, &swapped_language_buttons_);
+  TranslateInfoBarDelegate* delegate = GetDelegate();
+  delegate->GetAfterTranslateStrings(&strings, &swapped_language_buttons_);
   DCHECK_EQ(3U, strings.size());
 
   label_1_ = CreateLabel(strings[0]);
   AddChildView(label_1_);
 
   original_language_menu_button_ = CreateMenuButton(string16(), this);
+  original_language_menu_model_.reset(new TranslateLanguageMenuModel(
+      TranslateLanguageMenuModel::ORIGINAL, delegate, this,
+      original_language_menu_button_, true));
   target_language_menu_button_ = CreateMenuButton(string16(), this);
+  original_language_menu_model_.reset(new TranslateLanguageMenuModel(
+      TranslateLanguageMenuModel::TARGET, delegate, this,
+      target_language_menu_button_, true));
   AddChildView(swapped_language_buttons_ ?
       target_language_menu_button_ : original_language_menu_button_);
 
   label_2_ = CreateLabel(strings[1]);
   AddChildView(label_2_);
 
   AddChildView(swapped_language_buttons_ ?
       original_language_menu_button_ : target_language_menu_button_);
 
   label_3_ = CreateLabel(strings[2]);
   AddChildView(label_3_);
 
   revert_button_ = CreateTextButton(this,
       l10n_util::GetStringUTF16(IDS_TRANSLATE_INFOBAR_REVERT), false);
   AddChildView(revert_button_);
 
   options_menu_button_ = CreateMenuButton(
       l10n_util::GetStringUTF16(IDS_TRANSLATE_INFOBAR_OPTIONS), this);
   AddChildView(options_menu_button_);
 
   // This must happen after adding all other children so InfoBarView can ensure
   // the close button is the last child.
   TranslateInfoBarBase::ViewHierarchyChanged(is_add, parent, child);
 
   // These must happen after adding all children because they trigger layout,
   // which assumes that particular children (e.g. the close button) have already
   // been added.
-  OriginalLanguageChanged();
-  TargetLanguageChanged();
+  UpdateLanguageButtonText(original_language_menu_button_,
+      delegate->language_name_at(delegate->original_language_index()));
+  UpdateLanguageButtonText(target_language_menu_button_,
+      delegate->language_name_at(delegate->target_language_index()));
 }
 
 void AfterTranslateInfoBar::ButtonPressed(views::Button* sender,
                                           const ui::Event& event) {
   if (!owned())
     return;  // We're closing; don't call anything, it might access the owner.
   if (sender == revert_button_)
     GetDelegate()->RevertTranslation();
   else
     TranslateInfoBarBase::ButtonPressed(sender, event);
 }
 
 int AfterTranslateInfoBar::ContentMinimumWidth() const {
   return
       (kButtonInLabelSpacing +
            original_language_menu_button_->GetPreferredSize().width() +
            kButtonInLabelSpacing) +
       (kButtonInLabelSpacing +
            target_language_menu_button_->GetPreferredSize().width() +
            kButtonInLabelSpacing) +
       (kButtonInLabelSpacing + revert_button_->GetPreferredSize().width()) +
       (kEndOfLabelSpacing + options_menu_button_->GetPreferredSize().width());
 }
 
-void AfterTranslateInfoBar::OriginalLanguageChanged() {
-  // Tests can call this function when the infobar has never been added to a
-  // view hierarchy and thus there is no button.
-  if (original_language_menu_button_) {
-    UpdateLanguageButtonText(original_language_menu_button_,
-                             LanguagesMenuModel::ORIGINAL);
-  }
-}
-
-void AfterTranslateInfoBar::TargetLanguageChanged() {
-  // Tests can call this function when the infobar has never been added to a
-  // view hierarchy and thus there is no button.
-  if (target_language_menu_button_) {
-    UpdateLanguageButtonText(target_language_menu_button_,
-                             LanguagesMenuModel::TARGET);
-  }
-}
-
 void AfterTranslateInfoBar::OnMenuButtonClicked(views::View* source,
                                                 const gfx::Point& point) {
   if (!owned())
     return;  // We're closing; don't call anything, it might access the owner.
-  ui::MenuModel* menu_model = NULL;
-  views::MenuButton* button = NULL;
-  views::MenuItemView::AnchorPosition anchor = views::MenuItemView::TOPLEFT;
   if (source == original_language_menu_button_) {
-    menu_model = &original_language_menu_model_;
-    button = original_language_menu_button_;
+    RunMenuAt(original_language_menu_model_.get(),
+              original_language_menu_button_, views::MenuItemView::TOPLEFT);
   } else if (source == target_language_menu_button_) {
-    menu_model = &target_language_menu_model_;
-    button = target_language_menu_button_;
+    RunMenuAt(target_language_menu_model_.get(), target_language_menu_button_,
+              views::MenuItemView::TOPLEFT);
   } else {
     DCHECK_EQ(options_menu_button_, source);
-    menu_model = &options_menu_model_;
-    button = options_menu_button_;
-    anchor = views::MenuItemView::TOPRIGHT;
+    RunMenuAt(&options_menu_model_, options_menu_button_,
+              views::MenuItemView::TOPRIGHT);
   }
-  RunMenuAt(menu_model, button, anchor);
 }