Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(618)

Side by Side Diff: chrome/browser/ui/views/infobars/translate_language_menu_model.cc

Issue 10952016: Simplify the translate infobar code some. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/translate/languages_menu_model.h" 5 #include "chrome/browser/ui/views/infobars/translate_language_menu_model.h"
6 6
7 #include "base/metrics/histogram.h" 7 #include "base/metrics/histogram.h"
8 #include "chrome/browser/translate/translate_infobar_delegate.h" 8 #include "chrome/browser/translate/translate_infobar_delegate.h"
9 #include "chrome/browser/ui/views/infobars/translate_infobar_base.h"
9 10
10 LanguagesMenuModel::LanguagesMenuModel( 11 TranslateLanguageMenuModel::TranslateLanguageMenuModel(
11 TranslateInfoBarDelegate* translate_delegate, 12 LanguageType language_type,
12 LanguageType language_type) 13 TranslateInfoBarDelegate* infobar_delegate,
14 TranslateInfoBarBase* infobar,
15 views::MenuButton* button,
16 bool translate_on_change)
13 : ALLOW_THIS_IN_INITIALIZER_LIST(ui::SimpleMenuModel(this)), 17 : ALLOW_THIS_IN_INITIALIZER_LIST(ui::SimpleMenuModel(this)),
14 translate_infobar_delegate_(translate_delegate), 18 language_type_(language_type),
15 language_type_(language_type) { 19 infobar_delegate_(infobar_delegate),
16 for (size_t i = 0; i < translate_delegate->GetLanguageCount(); ++i) { 20 infobar_(infobar),
17 AddCheckItem(static_cast<int>(i), 21 button_(button),
18 translate_delegate->GetLanguageDisplayableNameAt(i)); 22 translate_on_change_(translate_on_change) {
19 } 23 for (size_t i = 0; i < infobar_delegate_->num_languages(); ++i)
24 AddCheckItem(static_cast<int>(i), infobar_delegate_->language_name_at(i));
20 } 25 }
21 26
22 LanguagesMenuModel::~LanguagesMenuModel() { 27 TranslateLanguageMenuModel::~TranslateLanguageMenuModel() {
23 } 28 }
24 29
25 bool LanguagesMenuModel::IsCommandIdChecked(int command_id) const { 30 bool TranslateLanguageMenuModel::IsCommandIdChecked(int command_id) const {
26 return static_cast<size_t>(command_id) == ((language_type_ == ORIGINAL) ? 31 return static_cast<size_t>(command_id) == GetLanguageIndex();
27 translate_infobar_delegate_->original_language_index() :
28 translate_infobar_delegate_->target_language_index());
29 } 32 }
30 33
31 bool LanguagesMenuModel::IsCommandIdEnabled(int command_id) const { 34 bool TranslateLanguageMenuModel::IsCommandIdEnabled(int command_id) const {
32 // Prevent the same language from being selectable in original and target. 35 // Prevent the same language from being selectable in original and target.
33 return static_cast<size_t>(command_id) != ((language_type_ == ORIGINAL) ? 36 return static_cast<size_t>(command_id) != ((language_type_ == ORIGINAL) ?
34 translate_infobar_delegate_->target_language_index() : 37 infobar_delegate_->target_language_index() :
35 translate_infobar_delegate_->original_language_index()); 38 infobar_delegate_->original_language_index());
36 } 39 }
37 40
38 bool LanguagesMenuModel::GetAcceleratorForCommandId( 41 bool TranslateLanguageMenuModel::GetAcceleratorForCommandId(
39 int command_id, 42 int command_id,
40 ui::Accelerator* accelerator) { 43 ui::Accelerator* accelerator) {
41 return false; 44 return false;
42 } 45 }
43 46
44 void LanguagesMenuModel::ExecuteCommand(int command_id) { 47 void TranslateLanguageMenuModel::ExecuteCommand(int command_id) {
45 size_t command_id_size_t = static_cast<size_t>(command_id); 48 size_t command_id_size_t = static_cast<size_t>(command_id);
46 if (language_type_ == ORIGINAL) { 49 if (language_type_ == ORIGINAL) {
47 UMA_HISTOGRAM_COUNTS("Translate.ModifyOriginalLang", 1); 50 UMA_HISTOGRAM_COUNTS("Translate.ModifyOriginalLang", 1);
48 translate_infobar_delegate_->SetOriginalLanguage(command_id_size_t); 51 infobar_delegate_->set_original_language_index(command_id_size_t);
49 return; 52 } else {
53 UMA_HISTOGRAM_COUNTS("Translate.ModifyTargetLang", 1);
54 infobar_delegate_->set_target_language_index(command_id_size_t);
50 } 55 }
51 UMA_HISTOGRAM_COUNTS("Translate.ModifyTargetLang", 1); 56 infobar_->UpdateLanguageButtonText(button_,
52 translate_infobar_delegate_->SetTargetLanguage(command_id_size_t); 57 infobar_delegate_->language_name_at(GetLanguageIndex()));
58 if (translate_on_change_)
59 infobar_delegate_->Translate();
53 } 60 }
61
62 size_t TranslateLanguageMenuModel::GetLanguageIndex() const {
63 return (language_type_ == ORIGINAL) ?
64 infobar_delegate_->original_language_index() :
65 infobar_delegate_->target_language_index();
66 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698