Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Side by Side Diff: chrome/browser/translate/options_menu_model.cc

Issue 10952016: Simplify the translate infobar code some. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/translate/options_menu_model.h" 5 #include "chrome/browser/translate/options_menu_model.h"
6 6
7 #include "base/metrics/histogram.h" 7 #include "base/metrics/histogram.h"
8 #include "chrome/app/chrome_command_ids.h" 8 #include "chrome/app/chrome_command_ids.h"
9 #include "chrome/browser/infobars/infobar_tab_helper.h" 9 #include "chrome/browser/infobars/infobar_tab_helper.h"
10 #include "chrome/browser/profiles/profile.h" 10 #include "chrome/browser/profiles/profile.h"
11 #include "chrome/browser/translate/translate_infobar_delegate.h" 11 #include "chrome/browser/translate/translate_infobar_delegate.h"
12 #include "chrome/common/url_constants.h" 12 #include "chrome/common/url_constants.h"
13 #include "content/public/browser/navigation_controller.h" 13 #include "content/public/browser/navigation_controller.h"
14 #include "content/public/browser/navigation_entry.h" 14 #include "content/public/browser/navigation_entry.h"
15 #include "content/public/browser/web_contents.h" 15 #include "content/public/browser/web_contents.h"
16 #include "grit/generated_resources.h" 16 #include "grit/generated_resources.h"
17 #include "grit/locale_settings.h" 17 #include "grit/locale_settings.h"
18 #include "ui/base/l10n/l10n_util.h" 18 #include "ui/base/l10n/l10n_util.h"
19 19
20 using content::NavigationEntry; 20 using content::NavigationEntry;
21 using content::OpenURLParams; 21 using content::OpenURLParams;
22 using content::Referrer; 22 using content::Referrer;
23 using content::WebContents; 23 using content::WebContents;
24 24
25 OptionsMenuModel::OptionsMenuModel( 25 OptionsMenuModel::OptionsMenuModel(
26 TranslateInfoBarDelegate* translate_delegate) 26 TranslateInfoBarDelegate* translate_delegate)
27 : ALLOW_THIS_IN_INITIALIZER_LIST(ui::SimpleMenuModel(this)), 27 : ALLOW_THIS_IN_INITIALIZER_LIST(ui::SimpleMenuModel(this)),
28 translate_infobar_delegate_(translate_delegate) { 28 translate_infobar_delegate_(translate_delegate) {
29 string16 original_language = translate_delegate->GetLanguageDisplayableNameAt( 29 string16 original_language = translate_delegate->language_name_at(
30 translate_delegate->original_language_index()); 30 translate_delegate->original_language_index());
31 string16 target_language = translate_delegate->GetLanguageDisplayableNameAt( 31 string16 target_language = translate_delegate->language_name_at(
32 translate_delegate->target_language_index()); 32 translate_delegate->target_language_index());
33 33
34 // Populate the menu. 34 // Populate the menu.
35 // Incognito mode does not get any preferences related items. 35 // Incognito mode does not get any preferences related items.
36 if (!translate_delegate->owner()->GetWebContents()-> 36 if (!translate_delegate->owner()->GetWebContents()->
37 GetBrowserContext()->IsOffTheRecord()) { 37 GetBrowserContext()->IsOffTheRecord()) {
38 AddCheckItem(IDC_TRANSLATE_OPTIONS_ALWAYS, 38 AddCheckItem(IDC_TRANSLATE_OPTIONS_ALWAYS,
39 l10n_util::GetStringFUTF16(IDS_TRANSLATE_INFOBAR_OPTIONS_ALWAYS, 39 l10n_util::GetStringFUTF16(IDS_TRANSLATE_INFOBAR_OPTIONS_ALWAYS,
40 original_language, target_language)); 40 original_language, target_language));
41 AddCheckItem(IDC_TRANSLATE_OPTIONS_NEVER_TRANSLATE_LANG, 41 AddCheckItem(IDC_TRANSLATE_OPTIONS_NEVER_TRANSLATE_LANG,
(...skipping 97 matching lines...) Expand 10 before | Expand all | Expand 10 after
139 web_contents->OpenURL(params); 139 web_contents->OpenURL(params);
140 } 140 }
141 break; 141 break;
142 } 142 }
143 143
144 default: 144 default:
145 NOTREACHED() << "Invalid command id from menu."; 145 NOTREACHED() << "Invalid command id from menu.";
146 break; 146 break;
147 } 147 }
148 } 148 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698