Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1059)

Unified Diff: chrome/browser/ui/cocoa/infobars/translate_infobar_unittest.mm

Issue 10952016: Simplify the translate infobar code some. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/infobars/translate_infobar_unittest.mm
===================================================================
--- chrome/browser/ui/cocoa/infobars/translate_infobar_unittest.mm (revision 157463)
+++ chrome/browser/ui/cocoa/infobars/translate_infobar_unittest.mm (working copy)
@@ -54,27 +54,16 @@
}
- virtual string16 GetDisplayNameForLocale(const std::string& language_code) {
- return ASCIIToUTF16("Foo");
- }
-
- virtual bool IsLanguageBlacklisted() {
- return false;
- }
-
- virtual bool IsSiteBlacklisted() {
- return false;
- }
-
- virtual bool ShouldAlwaysTranslate() {
- return false;
- }
-
MOCK_METHOD0(Translate, void());
MOCK_METHOD0(RevertTranslation, void());
+
MOCK_METHOD0(TranslationDeclined, void());
+
+ virtual bool IsLanguageBlacklisted() { return false; }
sail 2012/09/19 04:44:06 should these have OVERRIDE on them?
Peter Kasting 2012/09/19 04:53:32 Yes. Good catch.
MOCK_METHOD0(ToggleLanguageBlacklist, void());
+ virtual bool IsSiteBlacklisted() { return false; }
MOCK_METHOD0(ToggleSiteBlacklist, void());
+ virtual bool ShouldAlwaysTranslate() { return false; }
MOCK_METHOD0(ToggleAlwaysTranslate, void());
};

Powered by Google App Engine
This is Rietveld 408576698