Simplify the translate infobar code some.

chrome/browser/ui/cocoa/infobars/translate_infobar_base.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/infobars/translate_infobar_base.h"
 
 #include "base/logging.h"
 #include "base/metrics/histogram.h"
 #include "base/sys_string_conversions.h"
 #include "chrome/app/chrome_command_ids.h"
@@ skipping 83 matching lines @@
 - (void)populateLanguageMenus;
 
 @end
 
 #pragma mark TranslateInfoBarController class
 
 @implementation TranslateInfoBarControllerBase
 
 - (id)initWithDelegate:(InfoBarDelegate*)delegate
                  owner:(InfoBarService*)owner {
-  if ((self = [super initWithDelegate:delegate owner:owner])) {
-      originalLanguageMenuModel_.reset(
-          new LanguagesMenuModel([self delegate],
-                                 LanguagesMenuModel::ORIGINAL));
-
-      targetLanguageMenuModel_.reset(
-          new LanguagesMenuModel([self delegate],
-                                 LanguagesMenuModel::TARGET));
-  }
+  [super initWithDelegate:delegate owner:owner];

[Peter Kasting, 2012/09/19 00:42:02]

Can we just get rid of this function entirely or something?

[sail, 2012/09/19 02:13:31]

Yep!

[Peter Kasting, 2012/09/19 02:37:26]

OK, done.

   return self;
 }
 
 - (TranslateInfoBarDelegate*)delegate {
   return reinterpret_cast<TranslateInfoBarDelegate*>(delegate_);
 }
 
 - (void)constructViews {
   // Using a zero or very large frame causes GTMUILocalizerAndLayoutTweaker
   // to not resize the view properly so we take the bounds of the first label
   // which is contained in the nib.
   NSRect bogusFrame = [label_ frame];
   label1_.reset(CreateLabel(bogusFrame));
   label2_.reset(CreateLabel(bogusFrame));
   label3_.reset(CreateLabel(bogusFrame));
 
   optionsPopUp_.reset([[NSPopUpButton alloc] initWithFrame:bogusFrame
                                                  pullsDown:YES]);
   fromLanguagePopUp_.reset([[NSPopUpButton alloc] initWithFrame:bogusFrame
                                                       pullsDown:NO]);
   toLanguagePopUp_.reset([[NSPopUpButton alloc] initWithFrame:bogusFrame
-                                                     pullsDown:NO]);
+                                                    pullsDown:NO]);
   showOriginalButton_.reset([[NSButton alloc] init]);
   translateMessageButton_.reset([[NSButton alloc] init]);
 }
 
 - (void)sourceLanguageModified:(NSInteger)newLanguageIdx {
   size_t newLanguageIdxSizeT = static_cast<size_t>(newLanguageIdx);
   DCHECK_NE(TranslateInfoBarDelegate::kNoIndex, newLanguageIdxSizeT);
   if (newLanguageIdxSizeT == [self delegate]->original_language_index())
     return;
-  [self delegate]->SetOriginalLanguage(newLanguageIdxSizeT);
+  [self delegate]->set_original_language_index(newLanguageIdxSizeT);
+  if ([self delegate]->type() == TranslateInfoBarDelegate::AFTER_TRANSLATE)
+    [self delegate]->Translate();
   int commandId = IDC_TRANSLATE_ORIGINAL_LANGUAGE_BASE + newLanguageIdx;
   int newMenuIdx = [fromLanguagePopUp_ indexOfItemWithTag:commandId];
   [fromLanguagePopUp_ selectItemAtIndex:newMenuIdx];
 }
 
 - (void)targetLanguageModified:(NSInteger)newLanguageIdx {
   size_t newLanguageIdxSizeT = static_cast<size_t>(newLanguageIdx);
   DCHECK_NE(TranslateInfoBarDelegate::kNoIndex, newLanguageIdxSizeT);
   if (newLanguageIdxSizeT == [self delegate]->target_language_index())
     return;
-  [self delegate]->SetTargetLanguage(newLanguageIdxSizeT);
+  [self delegate]->set_target_language_index(newLanguageIdxSizeT);
+  if ([self delegate]->type() == TranslateInfoBarDelegate::AFTER_TRANSLATE)
+    [self delegate]->Translate();
   int commandId = IDC_TRANSLATE_TARGET_LANGUAGE_BASE + newLanguageIdx;
   int newMenuIdx = [toLanguagePopUp_ indexOfItemWithTag:commandId];
   [toLanguagePopUp_ selectItemAtIndex:newMenuIdx];
 }
 
 - (void)loadLabelText {
   // Do nothing by default, should be implemented by subclasses.
 }
 
 - (void)updateState {
@@ skipping 68 matching lines @@
   [optionsPopUp_ removeAllItems];
   // Set title.
   NSString* optionsLabel = hideTitle ? @"" :
       l10n_util::GetNSString(IDS_TRANSLATE_INFOBAR_OPTIONS);
   [optionsPopUp_ addItemWithTitle:optionsLabel];
 
    // Populate options menu.
   NSMenu* optionsMenu = [optionsPopUp_ menu];
   [optionsMenu setAutoenablesItems:NO];
   for (int i = 0; i < optionsMenuModel_->GetItemCount(); ++i) {
-    NSString* title = base::SysUTF16ToNSString(
-        optionsMenuModel_->GetLabelAt(i));
-    int cmd = optionsMenuModel_->GetCommandIdAt(i);
-    bool checked = optionsMenuModel_->IsItemCheckedAt(i);
-    bool enabled = optionsMenuModel_->IsEnabledAt(i);
     AddMenuItem(optionsMenu,
                 self,
                 @selector(optionsMenuChanged:),
-                title,
-                cmd,
-                enabled,
-                checked);
+                base::SysUTF16ToNSString(optionsMenuModel_->GetLabelAt(i)),
+                optionsMenuModel_->GetCommandIdAt(i),
+                optionsMenuModel_->IsEnabledAt(i),
+                optionsMenuModel_->IsItemCheckedAt(i));
   }
 }
 
 - (BOOL)shouldShowOptionsPopUp {
   return YES;
 }
 
 - (void)populateLanguageMenus {
   NSMenu* originalLanguageMenu = [fromLanguagePopUp_ menu];
   [originalLanguageMenu setAutoenablesItems:NO];
-  int selectedMenuIndex = 0;
-  int selectedLangIndex =
-      static_cast<int>([self delegate]->original_language_index());
-  for (int i = 0; i < originalLanguageMenuModel_->GetItemCount(); ++i) {
-    NSString* title = base::SysUTF16ToNSString(
-        originalLanguageMenuModel_->GetLabelAt(i));
-    int cmd = originalLanguageMenuModel_->GetCommandIdAt(i);
-    bool checked = (cmd == selectedLangIndex);
-    if (checked)
-      selectedMenuIndex = i;
-    bool enabled = originalLanguageMenuModel_->IsEnabledAt(i);
-    cmd += IDC_TRANSLATE_ORIGINAL_LANGUAGE_BASE;
+  NSMenu* targetLanguageMenu = [toLanguagePopUp_ menu];
+  [targetLanguageMenu setAutoenablesItems:NO];
+  for (size_t i = 0; i < [self delegate]->num_languages(); ++i) {
+    NSString* title =
+        base::SysUTF16ToNSString([self delegate]->language_name_at(i));
     AddMenuItem(originalLanguageMenu,
                 self,
                 @selector(languageMenuChanged:),
                 title,
-                cmd,
-                enabled,
-                checked);
-  }
-  [fromLanguagePopUp_ selectItemAtIndex:selectedMenuIndex];
-
-  NSMenu* targetLanguageMenu = [toLanguagePopUp_ menu];
-  [targetLanguageMenu setAutoenablesItems:NO];
-  selectedLangIndex =
-      static_cast<int>([self delegate]->target_language_index());
-  for (int i = 0; i < targetLanguageMenuModel_->GetItemCount(); ++i) {
-    NSString* title = base::SysUTF16ToNSString(
-        targetLanguageMenuModel_->GetLabelAt(i));
-    int cmd = targetLanguageMenuModel_->GetCommandIdAt(i);
-    bool checked = (cmd == selectedLangIndex);
-    if (checked)
-      selectedMenuIndex = i;
-    bool enabled = targetLanguageMenuModel_->IsEnabledAt(i);
-    cmd += IDC_TRANSLATE_TARGET_LANGUAGE_BASE;
+                IDC_TRANSLATE_ORIGINAL_LANGUAGE_BASE + i,
+                i != [self delegate]->target_language_index(),
+                i == [self delegate]->original_language_index());
     AddMenuItem(targetLanguageMenu,
                 self,
                 @selector(languageMenuChanged:),
                 title,
-                cmd,
-                enabled,
-                checked);
+                IDC_TRANSLATE_TARGET_LANGUAGE_BASE + i,
+                i != [self delegate]->original_language_index(),
+                i == [self delegate]->target_language_index());
   }
-  [toLanguagePopUp_ selectItemAtIndex:selectedMenuIndex];
+  [fromLanguagePopUp_
+      selectItemAtIndex:([self delegate]->original_language_index())];
+  [toLanguagePopUp_
+      selectItemAtIndex:([self delegate]->target_language_index())];
 }
 
 - (void)addAdditionalControls {
   using l10n_util::GetNSString;
   using l10n_util::GetNSStringWithFixup;
 
   // Get layout information from the NIB.
   NSRect okButtonFrame = [okButton_ frame];
   NSRect cancelButtonFrame = [cancelButton_ frame];
 
@@ skipping 255 matching lines @@
           [[control description] UTF8String] <<[title UTF8String];
       return false;
     }
     previousControl = control;
   }
 
   return true;
 }
 
 @end // TranslateInfoBarControllerBase (TestingAPI)