Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Side by Side Diff: chrome/browser/ui/gtk/infobars/translate_infobar_base_gtk.cc

Issue 10952016: Simplify the translate infobar code some. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/gtk/infobars/translate_infobar_base_gtk.h" 5 #include "chrome/browser/ui/gtk/infobars/translate_infobar_base_gtk.h"
6 6
7 #include "base/utf_string_conversions.h" 7 #include "base/utf_string_conversions.h"
8 #include "chrome/browser/infobars/infobar_tab_helper.h" 8 #include "chrome/browser/infobars/infobar_tab_helper.h"
9 #include "chrome/browser/translate/options_menu_model.h" 9 #include "chrome/browser/translate/options_menu_model.h"
10 #include "chrome/browser/translate/translate_infobar_delegate.h" 10 #include "chrome/browser/translate/translate_infobar_delegate.h"
(...skipping 126 matching lines...) Expand 10 before | Expand all | Expand 10 after
137 } 137 }
138 138
139 GtkWidget* TranslateInfoBarBase::CreateLanguageCombobox( 139 GtkWidget* TranslateInfoBarBase::CreateLanguageCombobox(
140 size_t selected_language, 140 size_t selected_language,
141 size_t exclude_language) { 141 size_t exclude_language) {
142 GtkListStore* model = gtk_list_store_new(LANGUAGE_COMBO_COLUMN_COUNT, 142 GtkListStore* model = gtk_list_store_new(LANGUAGE_COMBO_COLUMN_COUNT,
143 G_TYPE_INT, G_TYPE_STRING); 143 G_TYPE_INT, G_TYPE_STRING);
144 bool set_selection = false; 144 bool set_selection = false;
145 GtkTreeIter selected_iter; 145 GtkTreeIter selected_iter;
146 TranslateInfoBarDelegate* delegate = GetDelegate(); 146 TranslateInfoBarDelegate* delegate = GetDelegate();
147 for (size_t i = 0; i < delegate->GetLanguageCount(); ++i) { 147 for (size_t i = 0; i < delegate->num_languages(); ++i) {
148 if (i == exclude_language) 148 if (i == exclude_language)
149 continue; 149 continue;
150 GtkTreeIter tree_iter; 150 GtkTreeIter tree_iter;
151 const string16& name = delegate->GetLanguageDisplayableNameAt(i); 151 const string16& name = delegate->language_name_at(i);
152 152
153 gtk_list_store_append(model, &tree_iter); 153 gtk_list_store_append(model, &tree_iter);
154 gtk_list_store_set(model, &tree_iter, 154 gtk_list_store_set(model, &tree_iter,
155 LANGUAGE_COMBO_COLUMN_ID, i, 155 LANGUAGE_COMBO_COLUMN_ID, i,
156 LANGUAGE_COMBO_COLUMN_NAME, UTF16ToUTF8(name).c_str(), 156 LANGUAGE_COMBO_COLUMN_NAME, UTF16ToUTF8(name).c_str(),
157 -1); 157 -1);
158 if (i == selected_language) { 158 if (i == selected_language) {
159 selected_iter = tree_iter; 159 selected_iter = tree_iter;
160 set_selection = true; 160 set_selection = true;
161 } 161 }
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
208 case TRANSLATING: 208 case TRANSLATING:
209 case TRANSLATION_ERROR: 209 case TRANSLATION_ERROR:
210 infobar = new TranslateMessageInfoBar(helper, this); 210 infobar = new TranslateMessageInfoBar(helper, this);
211 break; 211 break;
212 default: 212 default:
213 NOTREACHED(); 213 NOTREACHED();
214 } 214 }
215 infobar->Init(); 215 infobar->Init();
216 return infobar; 216 return infobar;
217 } 217 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698