Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3248)

Unified Diff: chrome/browser/ui/views/infobars/translate_infobar_base.h

Issue 10952016: Simplify the translate infobar code some. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/infobars/translate_infobar_base.h
===================================================================
--- chrome/browser/ui/views/infobars/translate_infobar_base.h (revision 157463)
+++ chrome/browser/ui/views/infobars/translate_infobar_base.h (working copy)
@@ -6,8 +6,6 @@
#define CHROME_BROWSER_UI_VIEWS_INFOBARS_TRANSLATE_INFOBAR_BASE_H_
#include "base/compiler_specific.h"
-#include "chrome/browser/translate/languages_menu_model.h"
-#include "chrome/browser/translate/translate_infobar_view.h"
#include "chrome/browser/ui/views/infobars/infobar_background.h"
#include "chrome/browser/ui/views/infobars/infobar_view.h"
@@ -19,13 +17,16 @@
// This class contains some of the base functionality that translate infobars
// use.
-class TranslateInfoBarBase : public TranslateInfoBarView,
- public InfoBarView {
+class TranslateInfoBarBase : public InfoBarView {
public:
TranslateInfoBarBase(InfoBarTabHelper* owner,
TranslateInfoBarDelegate* delegate);
virtual ~TranslateInfoBarBase();
+ // Sets the text of the provided language menu button.
+ void UpdateLanguageButtonText(views::MenuButton* button,
+ const string16& text);
+
protected:
static const int kButtonInLabelSpacing;
@@ -34,11 +35,6 @@
View* parent,
View* child) OVERRIDE;
- // Sets the text of the provided language menu button to reflect the current
- // value from the delegate.
- void UpdateLanguageButtonText(views::MenuButton* button,
- LanguagesMenuModel::LanguageType language);
-
// Convenience to retrieve the TranslateInfoBarDelegate for this infobar.
TranslateInfoBarDelegate* GetDelegate();

Powered by Google App Engine
This is Rietveld 408576698