Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1216)

Issue 1057323002: MIPS: Major fixes and clean-up in asm. for instruction encoding. (Closed)

Created:
5 years, 8 months ago by dusmil.imgtec
Modified:
5 years, 8 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Major fixes and clean-up in asm. for instruction encoding. - Fixed single float register type instruction en[de]coding in assembler and disassembler. - Added max and min instructions for r6 and corresponding tests. - Fixed selection instruction for boundary cases in simulator. - Update assembler tests to be more thorough wrt boundary cases. TEST=cctest/test-assembler-mips64/MIPS17, MIPS18 cctest/test-disasm-mips64/Type1 cctest/test-assembler-mips/MIPS16, MIPS17 cctest/test-disasm-mips/Type1 BUG= Committed: https://crrev.com/4b5af7b32ec97fd127b4bf9e2b3cb4ec6f0d3c2e Cr-Commit-Position: refs/heads/master@{#27601}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Typos addressed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+527 lines, -506 lines) Patch
M src/mips/assembler-mips.h View 2 chunks +11 lines, -12 lines 0 comments Download
M src/mips/assembler-mips.cc View 1 2 chunks +25 lines, -14 lines 0 comments Download
M src/mips/constants-mips.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/mips/disasm-mips.cc View 6 chunks +74 lines, -146 lines 0 comments Download
M src/mips/simulator-mips.cc View 2 chunks +34 lines, -2 lines 0 comments Download
M src/mips64/assembler-mips64.h View 2 chunks +10 lines, -12 lines 0 comments Download
M src/mips64/assembler-mips64.cc View 4 chunks +25 lines, -26 lines 0 comments Download
M src/mips64/disasm-mips64.cc View 8 chunks +65 lines, -167 lines 0 comments Download
M src/mips64/simulator-mips64.h View 2 chunks +7 lines, -7 lines 0 comments Download
M src/mips64/simulator-mips64.cc View 1 6 chunks +45 lines, -13 lines 0 comments Download
M test/cctest/test-assembler-mips.cc View 2 chunks +96 lines, -46 lines 0 comments Download
M test/cctest/test-assembler-mips64.cc View 2 chunks +100 lines, -26 lines 0 comments Download
M test/cctest/test-disasm-mips.cc View 2 chunks +18 lines, -14 lines 0 comments Download
M test/cctest/test-disasm-mips64.cc View 2 chunks +17 lines, -19 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
dusmil.imgtec
5 years, 8 months ago (2015-04-03 17:12:06 UTC) #2
paul.l...
Please fix the indicated DCHECK, then LGTM. Nice cleanup. https://codereview.chromium.org/1057323002/diff/1/src/mips/assembler-mips.cc File src/mips/assembler-mips.cc (right): https://codereview.chromium.org/1057323002/diff/1/src/mips/assembler-mips.cc#newcode1925 src/mips/assembler-mips.cc:1925: ...
5 years, 8 months ago (2015-04-03 17:56:17 UTC) #3
dusmil.imgtec
Done. Thanks for catching these.
5 years, 8 months ago (2015-04-06 11:02:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1057323002/10001
5 years, 8 months ago (2015-04-06 11:06:10 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:10001)
5 years, 8 months ago (2015-04-06 11:54:45 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-04-06 11:54:55 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4b5af7b32ec97fd127b4bf9e2b3cb4ec6f0d3c2e
Cr-Commit-Position: refs/heads/master@{#27601}

Powered by Google App Engine
This is Rietveld 408576698