Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(609)

Unified Diff: test/cctest/test-disasm-mips.cc

Issue 1057323002: MIPS: Major fixes and clean-up in asm. for instruction encoding. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Typos addressed. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/cctest/test-assembler-mips64.cc ('k') | test/cctest/test-disasm-mips64.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-disasm-mips.cc
diff --git a/test/cctest/test-disasm-mips.cc b/test/cctest/test-disasm-mips.cc
index 1023ca445cc85a64c5422548e9b7276fea29f5ad..5789a23390f392edb6db3a0173ebc75698aff1b4 100644
--- a/test/cctest/test-disasm-mips.cc
+++ b/test/cctest/test-disasm-mips.cc
@@ -90,20 +90,6 @@ bool DisassembleAndCompare(byte* pc, const char* compare_string) {
if (failure) { \
V8_Fatal(__FILE__, __LINE__, "MIPS Disassembler tests failed.\n"); \
}
-// tests only seleqz, selnez, seleqz.fmt and selnez.fmt
-TEST(Type1) {
- SET_UP();
- if (IsMipsArchVariant(kMips32r6)) {
- COMPARE(seleqz(a0, a1, a2), "00853035 seleqz a0, a1, a2");
- COMPARE(selnez(a0, a1, a2), "00853037 selnez a0, a1, a2");
-
- COMPARE(seleqz(S, f0, f1, f2), "45000894 seleqz.S f0, f1, f2");
- COMPARE(selnez(S, f0, f1, f2), "45000897 selnez.S f0, f1, f2");
- COMPARE(seleqz(D, f3, f4, f5), "00853035 seleqz.D f3, f4, f5");
- COMPARE(selnez(D, f3, f4, f5), "00853037 selnez.D f3, f4, f5");
- }
- VERIFY_RUN();
-}
TEST(Type0) {
@@ -537,3 +523,21 @@ TEST(Type0) {
VERIFY_RUN();
}
+
+
+// Tests only seleqz, selnez, seleqz.fmt and selnez.fmt
+TEST(Type1) {
+ if (IsMipsArchVariant(kMips32r6)) {
+ SET_UP();
+ COMPARE(seleqz(a0, a1, a2), "00a62035 seleqz a0, a1, a2");
+ COMPARE(selnez(a0, a1, a2), "00a62037 selnez a0, a1, a2");
+
+
+ COMPARE(seleqz(D, f3, f4, f5), "462520d4 seleqz.d f3, f4, f5");
+ COMPARE(selnez(D, f3, f4, f5), "462520d7 selnez.d f3, f4, f5");
+
+ COMPARE(min(D, f3, f4, f5), "462520dc min.d f3, f4, f5");
+ COMPARE(max(D, f3, f4, f5), "462520de max.d f3, f4, f5");
+ VERIFY_RUN();
+ }
+}
« no previous file with comments | « test/cctest/test-assembler-mips64.cc ('k') | test/cctest/test-disasm-mips64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698