Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1032823003: Refactor HitTestResult to store the HitTestRequest (Closed)

Created:
5 years, 9 months ago by ramya.v
Modified:
5 years, 8 months ago
CC:
aandrey+blink_chromium.org, aboxhall, apavlov+blink_chromium.org, blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-events_chromium.org, blink-reviews-paint_chromium.org, blink-reviews-rendering, caseq+blink_chromium.org, dcheng, devtools-reviews_chromium.org, dglazkov+blink, dmazzoni, Dominik Röttsches, dshwang, krit, eae+blinkwatch, ed+blinkwatch_opera.com, eustas+blink_chromium.org, f(malita), fs, gyuyoung.kim_webkit.org, jchaffraix+rendering, je_julie(Not used), kouhei+svg_chromium.org, kozyatinskiy+blink_chromium.org, leviw+renderwatch, loislo+blink_chromium.org, lushnikov+blink_chromium.org, malch+blink_chromium.org, nektarios, pdr+svgwatchlist_chromium.org, pdr+renderingwatchlist_chromium.org, pdr., pfeldman+blink_chromium.org, rwlbuis, Stephen Chennney, sergeyv+blink_chromium.org, sof, slimming-paint-reviews_chromium.org, yurys+blink_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Refactor HitTestResult to store the HitTestRequest BUG=460804 TBR=dmazzoni@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192955

Patch Set 1 #

Patch Set 2 : Rebasing to latest #

Patch Set 3 : Rebasing #

Patch Set 4 : #

Total comments: 10

Patch Set 5 : Rebasing to latest #

Patch Set 6 : Updating as per review comments #

Total comments: 4

Patch Set 7 : Updated as per review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+290 lines, -284 lines) Patch
M Source/core/dom/Document.cpp View 1 2 3 4 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/dom/TreeScope.cpp View 1 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/editing/FrameSelection.cpp View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/frame/LocalFrame.cpp View 1 2 3 4 5 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/inspector/InspectorDOMAgent.cpp View 1 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/layout/HitTestResult.h View 4 chunks +8 lines, -6 lines 0 comments Download
M Source/core/layout/HitTestResult.cpp View 6 chunks +18 lines, -16 lines 0 comments Download
M Source/core/layout/LayoutBlock.h View 1 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/layout/LayoutBlock.cpp View 1 2 3 4 8 chunks +14 lines, -14 lines 0 comments Download
M Source/core/layout/LayoutBlockFlow.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/LayoutBlockFlow.cpp View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/layout/LayoutBox.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/LayoutBox.cpp View 1 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/layout/LayoutFlowThread.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/LayoutFlowThread.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/layout/LayoutImage.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/LayoutImage.cpp View 1 2 3 4 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/layout/LayoutInline.h View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/layout/LayoutInline.cpp View 1 2 3 4 3 chunks +5 lines, -5 lines 0 comments Download
M Source/core/layout/LayoutMultiColumnSpannerPlaceholder.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/LayoutMultiColumnSpannerPlaceholder.cpp View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/layout/LayoutObject.h View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/layout/LayoutObject.cpp View 1 2 3 4 3 chunks +7 lines, -7 lines 0 comments Download
M Source/core/layout/LayoutPart.h View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/layout/LayoutPart.cpp View 1 2 3 4 3 chunks +11 lines, -11 lines 0 comments Download
M Source/core/layout/LayoutTable.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/LayoutTable.cpp View 1 2 3 4 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/layout/LayoutTableRow.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/LayoutTableRow.cpp View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/layout/LayoutTableSection.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/LayoutTableSection.cpp View 1 2 3 4 3 chunks +5 lines, -5 lines 0 comments Download
M Source/core/layout/LayoutText.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/LayoutTextControlMultiLine.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/LayoutTextControlMultiLine.cpp View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/layout/LayoutTextControlSingleLine.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/LayoutTextControlSingleLine.cpp View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/layout/LayoutView.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/LayoutView.cpp View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/layout/line/EllipsisBox.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/line/EllipsisBox.cpp View 1 2 3 4 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/layout/line/InlineBox.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/line/InlineBox.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/layout/line/InlineFlowBox.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/line/InlineFlowBox.cpp View 1 2 3 4 4 chunks +6 lines, -6 lines 0 comments Download
M Source/core/layout/line/InlineTextBox.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/line/InlineTextBox.cpp View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/layout/line/LineBoxList.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/line/LineBoxList.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/layout/line/RootInlineBox.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/line/RootInlineBox.cpp View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/layout/svg/LayoutSVGBlock.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/svg/LayoutSVGBlock.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/svg/LayoutSVGContainer.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/svg/LayoutSVGContainer.cpp View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/layout/svg/LayoutSVGForeignObject.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/svg/LayoutSVGForeignObject.cpp View 1 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/layout/svg/LayoutSVGHiddenContainer.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/svg/LayoutSVGHiddenContainer.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/svg/LayoutSVGImage.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/svg/LayoutSVGImage.cpp View 1 2 chunks +3 lines, -2 lines 0 comments Download
M Source/core/layout/svg/LayoutSVGModelObject.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/svg/LayoutSVGModelObject.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/svg/LayoutSVGResourceClipper.cpp View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/layout/svg/LayoutSVGRoot.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/svg/LayoutSVGRoot.cpp View 1 2 3 4 4 chunks +5 lines, -5 lines 0 comments Download
M Source/core/layout/svg/LayoutSVGShape.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/svg/LayoutSVGShape.cpp View 1 2 3 4 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/layout/svg/LayoutSVGText.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/svg/LayoutSVGText.cpp View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/layout/svg/line/SVGInlineTextBox.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/svg/line/SVGInlineTextBox.cpp View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/page/ContextMenuController.cpp View 1 2 3 4 5 6 1 chunk +3 lines, -2 lines 0 comments Download
M Source/core/page/DragController.cpp View 1 2 3 4 5 2 chunks +3 lines, -4 lines 0 comments Download
M Source/core/page/EventHandler.cpp View 1 2 3 4 5 14 chunks +25 lines, -24 lines 0 comments Download
M Source/core/paint/DeprecatedPaintLayer.h View 1 2 3 4 3 chunks +9 lines, -9 lines 0 comments Download
M Source/core/paint/DeprecatedPaintLayer.cpp View 1 2 3 4 19 chunks +42 lines, -42 lines 0 comments Download
M Source/core/testing/Internals.cpp View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/accessibility/AXLayoutObject.cpp View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M Source/web/WebDevToolsAgentImpl.cpp View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M Source/web/WebLocalFrameImpl.cpp View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
ramya.v
PTAL!
5 years, 8 months ago (2015-03-30 08:29:31 UTC) #2
Rick Byers
Looks like a nice cleanup to me, thanks! Just a few minor suggestions. /cc eae@ ...
5 years, 8 months ago (2015-03-31 00:51:00 UTC) #4
eae
This is great! I agree with Ricks comments but other than that it looks good ...
5 years, 8 months ago (2015-03-31 01:15:18 UTC) #5
ramya.v
@Rick Updated the patch as per review comments. PTAL! Thanks. https://codereview.chromium.org/1032823003/diff/60001/Source/core/frame/LocalFrame.cpp File Source/core/frame/LocalFrame.cpp (right): https://codereview.chromium.org/1032823003/diff/60001/Source/core/frame/LocalFrame.cpp#newcode682 ...
5 years, 8 months ago (2015-03-31 09:41:36 UTC) #6
Rick Byers
PS5->PS6 diff LGTM with one minor nit. Thanks! +dmazzoni for OWNERS in modules/accessibility +aelias for ...
5 years, 8 months ago (2015-03-31 13:53:42 UTC) #8
aelias_OOO_until_Jul13
Source/web lgtm
5 years, 8 months ago (2015-03-31 18:47:57 UTC) #9
ramya.v
@Rick updated the patch as per review comments. PTAL! https://codereview.chromium.org/1032823003/diff/100001/Source/core/layout/svg/LayoutSVGResourceClipper.cpp File Source/core/layout/svg/LayoutSVGResourceClipper.cpp (right): https://codereview.chromium.org/1032823003/diff/100001/Source/core/layout/svg/LayoutSVGResourceClipper.cpp#newcode250 Source/core/layout/svg/LayoutSVGResourceClipper.cpp:250: ...
5 years, 8 months ago (2015-04-01 07:13:01 UTC) #10
Rick Byers
Still LGTM thanks. I added dmazzoni as TBR for modules/accessibility under the 'mechanical refactoring' rule: ...
5 years, 8 months ago (2015-04-01 16:32:11 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1032823003/120001
5 years, 8 months ago (2015-04-01 16:55:24 UTC) #15
commit-bot: I haz the power
5 years, 8 months ago (2015-04-01 18:22:34 UTC) #16
Message was sent while issue was closed. 
Committed patchset #7 (id:120001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192955

Powered by Google App Engine
This is Rietveld 408576698