Source/core/layout/svg/LayoutSVGForeignObject.h - Issue 1032823003: Refactor HitTestResult to store the HitTestRequest

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/layout/svg/LayoutSVGForeignObject.h

Issue 1032823003: Refactor HitTestResult to store the HitTestRequest (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Updated as per review comments Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/layout/svg/LayoutSVGForeignObject.h

diff --git a/Source/core/layout/svg/LayoutSVGForeignObject.h b/Source/core/layout/svg/LayoutSVGForeignObject.h

index 78df1cb833352be07974319ce3423c724dc25a2a..55a31f78c63d5c7c897876e84141ad3871bac0d9 100644

--- a/Source/core/layout/svg/LayoutSVGForeignObject.h

+++ b/Source/core/layout/svg/LayoutSVGForeignObject.h

@@ -44,7 +44,7 @@ public:

virtual FloatRect strokeBoundingBox() const override { return FloatRect(FloatPoint(), m_viewport.size()); }

virtual FloatRect paintInvalidationRectInLocalCoordinates() const override { return FloatRect(FloatPoint(), m_viewport.size()); }

- virtual bool nodeAtFloatPoint(const HitTestRequest&, HitTestResult&, const FloatPoint& pointInParent, HitTestAction) override;

+ virtual bool nodeAtFloatPoint(HitTestResult&, const FloatPoint& pointInParent, HitTestAction) override;

virtual bool isOfType(LayoutObjectType type) const override { return type == LayoutObjectSVGForeignObject || LayoutSVGBlock::isOfType(type); }

virtual void setNeedsTransformUpdate() override { m_needsTransformUpdate = true; }

« no previous file with comments | « Source/core/layout/svg/LayoutSVGContainer.cpp ('k') | Source/core/layout/svg/LayoutSVGForeignObject.cpp » ('j') | no next file with comments »