Source/web/WebDevToolsAgentImpl.cpp - Issue 1032823003: Refactor HitTestResult to store the HitTestRequest

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebDevToolsAgentImpl.cpp

Issue 1032823003: Refactor HitTestResult to store the HitTestRequest (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Updated as per review comments Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/WebDevToolsAgentImpl.cpp

diff --git a/Source/web/WebDevToolsAgentImpl.cpp b/Source/web/WebDevToolsAgentImpl.cpp

index 2c23dc64fead433ba3f801e8ad7690373307fa6d..68b177e1f26826181ae54b9e5137e6b8f1b790b1 100644

--- a/Source/web/WebDevToolsAgentImpl.cpp

+++ b/Source/web/WebDevToolsAgentImpl.cpp

@@ -658,8 +658,8 @@ void WebDevToolsAgentImpl::inspectElementAt(const WebPoint& pointInRootFrame)

dummyEvent.x = pointInRootFrame.x;

dummyEvent.y = pointInRootFrame.y;

IntPoint transformedPoint = PlatformMouseEventBuilder(m_webLocalFrameImpl->frameView(), dummyEvent).position();

- HitTestResult result(m_webLocalFrameImpl->frameView()->rootFrameToContents(transformedPoint));

- m_webLocalFrameImpl->frame()->contentRenderer()->hitTest(request, result);

+ HitTestResult result(request, m_webLocalFrameImpl->frameView()->rootFrameToContents(transformedPoint));

+ m_webLocalFrameImpl->frame()->contentRenderer()->hitTest(result);

Node* node = result.innerNode();

if (!node && m_webLocalFrameImpl->frame()->document())

node = m_webLocalFrameImpl->frame()->document()->documentElement();

« no previous file with comments | « Source/modules/accessibility/AXLayoutObject.cpp ('k') | Source/web/WebLocalFrameImpl.cpp » ('j') | no next file with comments »