Source/core/layout/svg/LayoutSVGModelObject.h - Issue 1032823003: Refactor HitTestResult to store the HitTestRequest

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/core/layout/svg/LayoutSVGModelObject.h

Issue 1032823003: Refactor HitTestResult to store the HitTestRequest (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Updated as per review comments Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « Source/core/layout/svg/LayoutSVGImage.cpp ('k') | Source/core/layout/svg/LayoutSVGModelObject.cpp » ('j') | no next file with comments »

OLD	NEW
1 /*	1 /*

2 * Copyright (c) 2009, Google Inc. All rights reserved.	2 * Copyright (c) 2009, Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions are	5 * modification, are permitted provided that the following conditions are

6 * met:	6 * met:

7 *	7 *

8 * * Redistributions of source code must retain the above copyright	8 * * Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * * Redistributions in binary form must reproduce the above	10 * * Redistributions in binary form must reproduce the above

(...skipping 55 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
66	66

67 protected:	67 protected:

68 virtual void addLayerHitTestRects(LayerHitTestRects&, const DeprecatedPaintL ayer* currentCompositedLayer, const LayoutPoint& layerOffset, const LayoutRect& containerRect) const override final;	68 virtual void addLayerHitTestRects(LayerHitTestRects&, const DeprecatedPaintL ayer* currentCompositedLayer, const LayoutPoint& layerOffset, const LayoutRect& containerRect) const override final;

69 virtual void willBeDestroyed() override;	69 virtual void willBeDestroyed() override;

70	70

71 private:	71 private:

72 // LayoutSVGModelObject subclasses should use element() instead.	72 // LayoutSVGModelObject subclasses should use element() instead.

73 void node() const = delete;	73 void node() const = delete;

74	74

75 // This method should never be called, SVG uses a different nodeAtPoint meth od	75 // This method should never be called, SVG uses a different nodeAtPoint meth od

76 virtual bool nodeAtPoint(const HitTestRequest&, HitTestResult&, const HitTes tLocation& locationInContainer, const LayoutPoint& accumulatedOffset, HitTestAct ion) override final;	76 virtual bool nodeAtPoint(HitTestResult&, const HitTestLocation& locationInCo ntainer, const LayoutPoint& accumulatedOffset, HitTestAction) override final;

77 virtual IntRect absoluteFocusRingBoundingBoxRect() const override final;	77 virtual IntRect absoluteFocusRingBoundingBoxRect() const override final;

78	78

79 virtual void invalidateTreeIfNeeded(PaintInvalidationState&) override final;	79 virtual void invalidateTreeIfNeeded(PaintInvalidationState&) override final;

80	80

81 protected:	81 protected:

82 FloatRect m_paintInvalidationBoundingBox;	82 FloatRect m_paintInvalidationBoundingBox;

83 };	83 };

84	84

85 }	85 }

86	86

87 #endif	87 #endif

OLD	NEW