Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(740)

Unified Diff: Source/core/layout/LayoutTableSection.cpp

Issue 1032823003: Refactor HitTestResult to store the HitTestRequest (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Updated as per review comments Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/layout/LayoutTableSection.h ('k') | Source/core/layout/LayoutText.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/layout/LayoutTableSection.cpp
diff --git a/Source/core/layout/LayoutTableSection.cpp b/Source/core/layout/LayoutTableSection.cpp
index 13246df082465c7302f8b4d8f5f3b2f2f07a2f5e..4036141f9a428ee38aa2fc4c6ce27050527bb94d 100644
--- a/Source/core/layout/LayoutTableSection.cpp
+++ b/Source/core/layout/LayoutTableSection.cpp
@@ -1501,7 +1501,7 @@ void LayoutTableSection::splitColumn(unsigned pos, unsigned first)
}
// Hit Testing
-bool LayoutTableSection::nodeAtPoint(const HitTestRequest& request, HitTestResult& result, const HitTestLocation& locationInContainer, const LayoutPoint& accumulatedOffset, HitTestAction action)
+bool LayoutTableSection::nodeAtPoint(HitTestResult& result, const HitTestLocation& locationInContainer, const LayoutPoint& accumulatedOffset, HitTestAction action)
{
// If we have no children then we have nothing to do.
if (!firstRow())
@@ -1522,7 +1522,7 @@ bool LayoutTableSection::nodeAtPoint(const HitTestRequest& request, HitTestResul
// then we can remove this check.
if (!row->hasSelfPaintingLayer()) {
LayoutPoint childPoint = flipForWritingModeForChild(row, adjustedLocation);
- if (row->nodeAtPoint(request, result, locationInContainer, childPoint, action)) {
+ if (row->nodeAtPoint(result, locationInContainer, childPoint, action)) {
updateHitTestResult(result, toLayoutPoint(locationInContainer.point() - childPoint));
return true;
}
@@ -1553,15 +1553,15 @@ bool LayoutTableSection::nodeAtPoint(const HitTestRequest& request, HitTestResul
--i;
LayoutTableCell* cell = current.cells[i];
LayoutPoint cellPoint = flipForWritingModeForChild(cell, adjustedLocation);
- if (static_cast<LayoutObject*>(cell)->nodeAtPoint(request, result, locationInContainer, cellPoint, action)) {
+ if (static_cast<LayoutObject*>(cell)->nodeAtPoint(result, locationInContainer, cellPoint, action)) {
updateHitTestResult(result, locationInContainer.point() - toLayoutSize(cellPoint));
return true;
}
}
- if (!request.listBased())
+ if (!result.hitTestRequest().listBased())
break;
}
- if (!request.listBased())
+ if (!result.hitTestRequest().listBased())
break;
}
« no previous file with comments | « Source/core/layout/LayoutTableSection.h ('k') | Source/core/layout/LayoutText.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698