Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Side by Side Diff: Source/core/testing/Internals.cpp

Issue 1032823003: Refactor HitTestResult to store the HitTestRequest (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Updated as per review comments Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * Copyright (C) 2013 Apple Inc. All rights reserved. 3 * Copyright (C) 2013 Apple Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 8 *
9 * 1. Redistributions of source code must retain the above copyright 9 * 1. Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 1354 matching lines...) Expand 10 before | Expand all | Expand 10 after
1365 if (allowChildFrameContent) 1365 if (allowChildFrameContent)
1366 hitType |= HitTestRequest::AllowChildFrameContent; 1366 hitType |= HitTestRequest::AllowChildFrameContent;
1367 1367
1368 HitTestRequest request(hitType); 1368 HitTestRequest request(hitType);
1369 1369
1370 // When ignoreClipping is false, this method returns null for coordinates ou tside of the viewport. 1370 // When ignoreClipping is false, this method returns null for coordinates ou tside of the viewport.
1371 if (!request.ignoreClipping() && !frameView->visibleContentRect().intersects (HitTestLocation::rectForPoint(point, topPadding, rightPadding, bottomPadding, l eftPadding))) 1371 if (!request.ignoreClipping() && !frameView->visibleContentRect().intersects (HitTestLocation::rectForPoint(point, topPadding, rightPadding, bottomPadding, l eftPadding)))
1372 return nullptr; 1372 return nullptr;
1373 1373
1374 WillBeHeapVector<RefPtrWillBeMember<Node>> matches; 1374 WillBeHeapVector<RefPtrWillBeMember<Node>> matches;
1375 HitTestResult result(point, topPadding, rightPadding, bottomPadding, leftPad ding); 1375 HitTestResult result(request, point, topPadding, rightPadding, bottomPadding , leftPadding);
1376 layoutView->hitTest(request, result); 1376 layoutView->hitTest(result);
1377 copyToVector(result.listBasedTestResult(), matches); 1377 copyToVector(result.listBasedTestResult(), matches);
1378 1378
1379 return StaticNodeList::adopt(matches); 1379 return StaticNodeList::adopt(matches);
1380 } 1380 }
1381 1381
1382 bool Internals::hasSpellingMarker(Document* document, int from, int length) 1382 bool Internals::hasSpellingMarker(Document* document, int from, int length)
1383 { 1383 {
1384 ASSERT(document); 1384 ASSERT(document);
1385 if (!document->frame()) 1385 if (!document->frame())
1386 return false; 1386 return false;
(...skipping 944 matching lines...) Expand 10 before | Expand all | Expand 10 after
2331 { 2331 {
2332 return frame()->selection().selectedTextForClipboard(); 2332 return frame()->selection().selectedTextForClipboard();
2333 } 2333 }
2334 2334
2335 ValueIterable<int>::IterationSource* Internals::startIteration(ScriptState*, Exc eptionState&) 2335 ValueIterable<int>::IterationSource* Internals::startIteration(ScriptState*, Exc eptionState&)
2336 { 2336 {
2337 return new InternalsIterationSource(); 2337 return new InternalsIterationSource();
2338 } 2338 }
2339 2339
2340 } // namespace blink 2340 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/paint/DeprecatedPaintLayer.cpp ('k') | Source/modules/accessibility/AXLayoutObject.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698