Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Side by Side Diff: Source/core/layout/LayoutFlowThread.h

Issue 1032823003: Refactor HitTestResult to store the HitTestRequest (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Updated as per review comments Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/layout/LayoutBox.cpp ('k') | Source/core/layout/LayoutFlowThread.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Adobe Systems Incorporated. All rights reserved. 2 * Copyright (C) 2011 Adobe Systems Incorporated. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above 8 * 1. Redistributions of source code must retain the above
9 * copyright notice, this list of conditions and the following 9 * copyright notice, this list of conditions and the following
10 * disclaimer. 10 * disclaimer.
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
67 // Skip past a column spanner during flow thread layout. Spanners are not la id out inside the 67 // Skip past a column spanner during flow thread layout. Spanners are not la id out inside the
68 // flow thread, since the flow thread is not in a spanner's containing block chain (since the 68 // flow thread, since the flow thread is not in a spanner's containing block chain (since the
69 // containing block is the multicol container). If the spanner follows right after a column set 69 // containing block is the multicol container). If the spanner follows right after a column set
70 // (as opposed to following another spanner), we may have to stretch the flo w thread to ensure 70 // (as opposed to following another spanner), we may have to stretch the flo w thread to ensure
71 // completely filled columns in the preceding column set. Return this adjust ment, if any. 71 // completely filled columns in the preceding column set. Return this adjust ment, if any.
72 virtual LayoutUnit skipColumnSpanner(LayoutBox*, LayoutUnit logicalTopInFlow Thread) { return LayoutUnit(); } 72 virtual LayoutUnit skipColumnSpanner(LayoutBox*, LayoutUnit logicalTopInFlow Thread) { return LayoutUnit(); }
73 73
74 virtual void flowThreadDescendantWasInserted(LayoutObject*) { } 74 virtual void flowThreadDescendantWasInserted(LayoutObject*) { }
75 virtual void flowThreadDescendantWillBeRemoved(LayoutObject*) { } 75 virtual void flowThreadDescendantWillBeRemoved(LayoutObject*) { }
76 76
77 virtual bool nodeAtPoint(const HitTestRequest&, HitTestResult&, const HitTes tLocation& locationInContainer, const LayoutPoint& accumulatedOffset, HitTestAct ion) override final; 77 virtual bool nodeAtPoint(HitTestResult&, const HitTestLocation& locationInCo ntainer, const LayoutPoint& accumulatedOffset, HitTestAction) override final;
78 78
79 virtual void addRegionToThread(LayoutMultiColumnSet*) = 0; 79 virtual void addRegionToThread(LayoutMultiColumnSet*) = 0;
80 virtual void removeRegionFromThread(LayoutMultiColumnSet*); 80 virtual void removeRegionFromThread(LayoutMultiColumnSet*);
81 81
82 virtual void computeLogicalHeight(LayoutUnit logicalHeight, LayoutUnit logic alTop, LogicalExtentComputedValues&) const override; 82 virtual void computeLogicalHeight(LayoutUnit logicalHeight, LayoutUnit logic alTop, LogicalExtentComputedValues&) const override;
83 83
84 bool hasRegions() const { return m_multiColumnSetList.size(); } 84 bool hasRegions() const { return m_multiColumnSetList.size(); }
85 85
86 void validateRegions(); 86 void validateRegions();
87 void invalidateRegions(); 87 void invalidateRegions();
(...skipping 81 matching lines...) Expand 10 before | Expand all | Expand 10 after
169 }; 169 };
170 170
171 template <> struct ValueToString<LayoutMultiColumnSet*> { 171 template <> struct ValueToString<LayoutMultiColumnSet*> {
172 static String string(const LayoutMultiColumnSet* value) { return String::for mat("%p", value); } 172 static String string(const LayoutMultiColumnSet* value) { return String::for mat("%p", value); }
173 }; 173 };
174 #endif 174 #endif
175 175
176 } // namespace blink 176 } // namespace blink
177 177
178 #endif // LayoutFlowThread_h 178 #endif // LayoutFlowThread_h
OLDNEW
« no previous file with comments | « Source/core/layout/LayoutBox.cpp ('k') | Source/core/layout/LayoutFlowThread.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698