Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1343373003: Revert "VM: New calling convention for generated code." (Closed)

Created:
5 years, 3 months ago by Florian Schneider
Modified:
5 years, 3 months ago
Reviewers:
Bill Hesse
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "VM: New calling convention for generated code." This reverts commit 1d343e5a7b75168fb6c9f86b64c55173cdbdc9b2. Because of Windows test failures. BUG= TBR=whesse@google.com Committed: https://github.com/dart-lang/sdk/commit/7af7a2db8764dc7e86917e673f879744d931df98

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2243 lines, -1710 lines) Patch
M runtime/vm/assembler.h View 2 chunks +2 lines, -10 lines 0 comments Download
M runtime/vm/assembler.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M runtime/vm/assembler_arm.h View 8 chunks +19 lines, -21 lines 0 comments Download
M runtime/vm/assembler_arm.cc View 11 chunks +80 lines, -100 lines 0 comments Download
M runtime/vm/assembler_arm64.h View 5 chunks +14 lines, -14 lines 0 comments Download
M runtime/vm/assembler_arm64.cc View 10 chunks +64 lines, -68 lines 0 comments Download
M runtime/vm/assembler_arm64_test.cc View 7 chunks +26 lines, -46 lines 0 comments Download
M runtime/vm/assembler_ia32.h View 3 chunks +1 line, -9 lines 0 comments Download
M runtime/vm/assembler_ia32.cc View 6 chunks +28 lines, -18 lines 0 comments Download
M runtime/vm/assembler_mips.h View 6 chunks +22 lines, -18 lines 0 comments Download
M runtime/vm/assembler_mips.cc View 10 chunks +82 lines, -90 lines 0 comments Download
M runtime/vm/assembler_mips_test.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M runtime/vm/assembler_x64.h View 6 chunks +21 lines, -8 lines 0 comments Download
M runtime/vm/assembler_x64.cc View 7 chunks +46 lines, -79 lines 0 comments Download
M runtime/vm/assembler_x64_test.cc View 10 chunks +25 lines, -44 lines 0 comments Download
M runtime/vm/block_scheduler.cc View 1 chunk +1 line, -2 lines 0 comments Download
M runtime/vm/code_generator.cc View 9 chunks +38 lines, -29 lines 0 comments Download
M runtime/vm/code_patcher.h View 4 chunks +20 lines, -12 lines 0 comments Download
M runtime/vm/code_patcher.cc View 2 chunks +83 lines, -6 lines 0 comments Download
M runtime/vm/code_patcher_arm.cc View 2 chunks +25 lines, -16 lines 0 comments Download
M runtime/vm/code_patcher_arm64.cc View 5 chunks +29 lines, -20 lines 0 comments Download
M runtime/vm/code_patcher_ia32.cc View 6 chunks +77 lines, -49 lines 0 comments Download
M runtime/vm/code_patcher_mips.cc View 2 chunks +25 lines, -16 lines 0 comments Download
M runtime/vm/code_patcher_x64.cc View 7 chunks +52 lines, -63 lines 0 comments Download
M runtime/vm/compiler.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M runtime/vm/constants_arm.h View 2 chunks +7 lines, -8 lines 0 comments Download
M runtime/vm/constants_arm64.h View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/constants_ia32.h View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/constants_mips.h View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/constants_x64.h View 1 chunk +1 line, -2 lines 0 comments Download
M runtime/vm/dart_entry.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/dart_entry.cc View 1 chunk +20 lines, -10 lines 0 comments Download
M runtime/vm/debugger.h View 3 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/debugger.cc View 4 chunks +4 lines, -7 lines 0 comments Download
M runtime/vm/debugger_arm.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M runtime/vm/debugger_arm64.cc View 2 chunks +5 lines, -6 lines 0 comments Download
M runtime/vm/debugger_ia32.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M runtime/vm/debugger_mips.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M runtime/vm/debugger_x64.cc View 2 chunks +5 lines, -6 lines 0 comments Download
M runtime/vm/deferred_objects.cc View 2 chunks +8 lines, -2 lines 0 comments Download
M runtime/vm/deopt_instructions.h View 3 chunks +1 line, -6 lines 0 comments Download
M runtime/vm/deopt_instructions.cc View 3 chunks +3 lines, -14 lines 0 comments Download
M runtime/vm/disassembler_arm.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/disassembler_ia32.cc View 1 chunk +1 line, -2 lines 0 comments Download
M runtime/vm/flow_graph_compiler.h View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/flow_graph_compiler.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M runtime/vm/flow_graph_compiler_arm.cc View 15 chunks +63 lines, -38 lines 0 comments Download
M runtime/vm/flow_graph_compiler_arm64.cc View 9 chunks +26 lines, -5 lines 0 comments Download
M runtime/vm/flow_graph_compiler_ia32.cc View 9 chunks +19 lines, -5 lines 0 comments Download
M runtime/vm/flow_graph_compiler_mips.cc View 11 chunks +38 lines, -13 lines 0 comments Download
M runtime/vm/flow_graph_compiler_x64.cc View 10 chunks +39 lines, -11 lines 0 comments Download
M runtime/vm/gc_marker.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M runtime/vm/instructions_arm.h View 4 chunks +27 lines, -8 lines 0 comments Download
M runtime/vm/instructions_arm.cc View 9 chunks +124 lines, -27 lines 0 comments Download
M runtime/vm/instructions_arm64.h View 4 chunks +29 lines, -8 lines 0 comments Download
M runtime/vm/instructions_arm64.cc View 6 chunks +79 lines, -21 lines 0 comments Download
M runtime/vm/instructions_arm64_test.cc View 1 chunk +33 lines, -2 lines 0 comments Download
M runtime/vm/instructions_arm_test.cc View 1 chunk +73 lines, -1 line 0 comments Download
M runtime/vm/instructions_ia32.h View 1 chunk +17 lines, -0 lines 0 comments Download
M runtime/vm/instructions_ia32_test.cc View 2 chunks +36 lines, -1 line 0 comments Download
M runtime/vm/instructions_mips.h View 4 chunks +32 lines, -8 lines 0 comments Download
M runtime/vm/instructions_mips.cc View 7 chunks +57 lines, -21 lines 0 comments Download
M runtime/vm/instructions_mips_test.cc View 1 chunk +33 lines, -1 line 0 comments Download
M runtime/vm/instructions_x64.h View 1 chunk +24 lines, -0 lines 0 comments Download
M runtime/vm/instructions_x64.cc View 1 chunk +21 lines, -0 lines 0 comments Download
M runtime/vm/instructions_x64_test.cc View 1 chunk +28 lines, -0 lines 0 comments Download
M runtime/vm/intermediate_language.cc View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/intermediate_language_arm.cc View 6 chunks +9 lines, -11 lines 0 comments Download
M runtime/vm/intermediate_language_arm64.cc View 3 chunks +2 lines, -11 lines 0 comments Download
M runtime/vm/intermediate_language_ia32.cc View 1 chunk +5 lines, -7 lines 0 comments Download
M runtime/vm/intermediate_language_mips.cc View 3 chunks +10 lines, -10 lines 0 comments Download
M runtime/vm/intermediate_language_x64.cc View 3 chunks +3 lines, -13 lines 0 comments Download
M runtime/vm/intrinsifier_arm.cc View 17 chunks +28 lines, -32 lines 0 comments Download
M runtime/vm/intrinsifier_arm64.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/intrinsifier_mips.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/intrinsifier_x64.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M runtime/vm/native_entry.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M runtime/vm/object.h View 11 chunks +47 lines, -33 lines 0 comments Download
M runtime/vm/object.cc View 14 chunks +42 lines, -19 lines 0 comments Download
M runtime/vm/raw_object.h View 8 chunks +14 lines, -11 lines 0 comments Download
M runtime/vm/raw_object.cc View 3 chunks +16 lines, -18 lines 0 comments Download
M runtime/vm/raw_object_snapshot.cc View 4 chunks +11 lines, -1 line 0 comments Download
M runtime/vm/runtime_entry_list.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/stack_frame.h View 1 chunk +1 line, -6 lines 0 comments Download
M runtime/vm/stack_frame.cc View 3 chunks +14 lines, -10 lines 0 comments Download
M runtime/vm/stack_frame_arm.h View 2 chunks +8 lines, -8 lines 0 comments Download
M runtime/vm/stack_frame_arm64.h View 2 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/stack_frame_ia32.h View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/stack_frame_mips.h View 2 chunks +7 lines, -7 lines 0 comments Download
M runtime/vm/stack_frame_x64.h View 2 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/stub_code.h View 2 chunks +3 lines, -8 lines 0 comments Download
M runtime/vm/stub_code.cc View 3 chunks +10 lines, -3 lines 0 comments Download
M runtime/vm/stub_code_arm.cc View 49 chunks +75 lines, -111 lines 0 comments Download
M runtime/vm/stub_code_arm64.cc View 32 chunks +35 lines, -69 lines 0 comments Download
M runtime/vm/stub_code_ia32.cc View 15 chunks +27 lines, -38 lines 0 comments Download
M runtime/vm/stub_code_mips.cc View 43 chunks +68 lines, -93 lines 0 comments Download
M runtime/vm/stub_code_x64.cc View 49 chunks +99 lines, -130 lines 0 comments Download
M runtime/vm/thread.h View 2 chunks +0 lines, -8 lines 0 comments Download
M runtime/vm/unit_test.h View 2 chunks +13 lines, -15 lines 0 comments Download
M runtime/vm/weak_code.cc View 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Florian Schneider
5 years, 3 months ago (2015-09-16 11:45:48 UTC) #1
Florian Schneider
Committed patchset #1 (id:1) manually as 7af7a2db8764dc7e86917e673f879744d931df98.
5 years, 3 months ago (2015-09-16 11:46:10 UTC) #2
Bill Hesse
5 years, 3 months ago (2015-09-16 11:50:19 UTC) #3
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698