Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Side by Side Diff: runtime/vm/debugger_arm.cc

Issue 1343373003: Revert "VM: New calling convention for generated code." (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/debugger.cc ('k') | runtime/vm/debugger_arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" 5 #include "vm/globals.h"
6 #if defined(TARGET_ARCH_ARM) 6 #if defined(TARGET_ARCH_ARM)
7 7
8 #include "vm/code_patcher.h" 8 #include "vm/code_patcher.h"
9 #include "vm/cpu.h" 9 #include "vm/cpu.h"
10 #include "vm/debugger.h" 10 #include "vm/debugger.h"
11 #include "vm/instructions.h" 11 #include "vm/instructions.h"
12 #include "vm/stub_code.h" 12 #include "vm/stub_code.h"
13 13
14 namespace dart { 14 namespace dart {
15 15
16 RawCode* CodeBreakpoint::OrigStubAddress() const { 16 uword CodeBreakpoint::OrigStubAddress() const {
17 return saved_value_; 17 return saved_value_;
18 } 18 }
19 19
20 20
21 void CodeBreakpoint::PatchCode() { 21 void CodeBreakpoint::PatchCode() {
22 ASSERT(!is_enabled_); 22 ASSERT(!is_enabled_);
23 Code& stub_target = Code::Handle(); 23 uword stub_target = 0;
24 switch (breakpoint_kind_) { 24 switch (breakpoint_kind_) {
25 case RawPcDescriptors::kIcCall: 25 case RawPcDescriptors::kIcCall:
26 case RawPcDescriptors::kUnoptStaticCall: 26 case RawPcDescriptors::kUnoptStaticCall:
27 stub_target = StubCode::ICCallBreakpoint_entry()->code(); 27 stub_target = StubCode::ICCallBreakpoint_entry()->EntryPoint();
28 break; 28 break;
29 case RawPcDescriptors::kRuntimeCall: 29 case RawPcDescriptors::kRuntimeCall:
30 stub_target = StubCode::RuntimeCallBreakpoint_entry()->code(); 30 stub_target = StubCode::RuntimeCallBreakpoint_entry()->EntryPoint();
31 break; 31 break;
32 default: 32 default:
33 UNREACHABLE(); 33 UNREACHABLE();
34 } 34 }
35 const Code& code = Code::Handle(code_); 35 const Code& code = Code::Handle(code_);
36 saved_value_ = CodePatcher::GetStaticCallTargetAt(pc_, code); 36 saved_value_ = CodePatcher::GetStaticCallTargetAt(pc_, code);
37 CodePatcher::PatchStaticCallAt(pc_, code, stub_target); 37 CodePatcher::PatchStaticCallAt(pc_, code, stub_target);
38 is_enabled_ = true; 38 is_enabled_ = true;
39 } 39 }
40 40
41 41
42 void CodeBreakpoint::RestoreCode() { 42 void CodeBreakpoint::RestoreCode() {
43 ASSERT(is_enabled_); 43 ASSERT(is_enabled_);
44 const Code& code = Code::Handle(code_); 44 const Code& code = Code::Handle(code_);
45 switch (breakpoint_kind_) { 45 switch (breakpoint_kind_) {
46 case RawPcDescriptors::kIcCall: 46 case RawPcDescriptors::kIcCall:
47 case RawPcDescriptors::kUnoptStaticCall: 47 case RawPcDescriptors::kUnoptStaticCall:
48 case RawPcDescriptors::kRuntimeCall: { 48 case RawPcDescriptors::kRuntimeCall: {
49 CodePatcher::PatchStaticCallAt(pc_, code, Code::Handle(saved_value_)); 49 CodePatcher::PatchStaticCallAt(pc_, code, saved_value_);
50 break; 50 break;
51 } 51 }
52 default: 52 default:
53 UNREACHABLE(); 53 UNREACHABLE();
54 } 54 }
55 is_enabled_ = false; 55 is_enabled_ = false;
56 } 56 }
57 57
58 } // namespace dart 58 } // namespace dart
59 59
60 #endif // defined TARGET_ARCH_ARM 60 #endif // defined TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « runtime/vm/debugger.cc ('k') | runtime/vm/debugger_arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698