Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Unified Diff: runtime/vm/stack_frame_ia32.h

Issue 1343373003: Revert "VM: New calling convention for generated code." (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/stack_frame_arm64.h ('k') | runtime/vm/stack_frame_mips.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/stack_frame_ia32.h
diff --git a/runtime/vm/stack_frame_ia32.h b/runtime/vm/stack_frame_ia32.h
index 29d0c43c4f30d9b1d8de5a03d4bd2911d869f6ba..f1a379b52e2ca1cbf07ca41c624647a1e3a37643 100644
--- a/runtime/vm/stack_frame_ia32.h
+++ b/runtime/vm/stack_frame_ia32.h
@@ -16,7 +16,7 @@ Callee frame | ... |
+--------------------+
Current frame | ... T| <- ESP of current frame
| first local T|
- | code object T| (current frame's code object)
+ | PC marker | (current frame's code entry + offset)
| caller's EBP | <- EBP of current frame
| caller's ret addr | (PC of caller frame)
+--------------------+
@@ -29,7 +29,7 @@ Caller frame | last parameter | <- ESP of caller frame
static const int kDartFrameFixedSize = 3; // PC marker, EBP, PC.
static const int kSavedPcSlotFromSp = -1;
-static const int kFirstObjectSlotFromFp = -1; // Used by GC to traverse stack.
+static const int kFirstObjectSlotFromFp = -2; // Used by GC to traverse stack.
static const int kFirstLocalSlotFromFp = -2;
static const int kPcMarkerSlotFromFp = -1;
« no previous file with comments | « runtime/vm/stack_frame_arm64.h ('k') | runtime/vm/stack_frame_mips.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698