Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(887)

Unified Diff: runtime/vm/stack_frame_arm64.h

Issue 1343373003: Revert "VM: New calling convention for generated code." (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/stack_frame_arm.h ('k') | runtime/vm/stack_frame_ia32.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/stack_frame_arm64.h
diff --git a/runtime/vm/stack_frame_arm64.h b/runtime/vm/stack_frame_arm64.h
index 6a5a1dabaccb716fd7ad3f94b58070e520640c40..f2528971a227e044eb4a634e21a03c02757c36cf 100644
--- a/runtime/vm/stack_frame_arm64.h
+++ b/runtime/vm/stack_frame_arm64.h
@@ -11,14 +11,14 @@ namespace dart {
| | <- TOS
Callee frame | ... |
| saved PP |
- | code object |
+ | callee's PC marker |
| saved FP | (FP of current frame)
| saved PC | (PC of current frame)
+--------------------+
Current frame | ... T| <- SP of current frame
| first local T|
| caller's PP T|
- | code object T| (current frame's code object)
+ | PC marker | (current frame's code entry + offset)
| caller's FP | <- FP of current frame
| caller's LR | (PC of caller frame)
+--------------------+
@@ -31,7 +31,7 @@ Caller frame | last parameter | <- SP of caller frame
static const int kDartFrameFixedSize = 4; // PP, FP, LR, PC marker.
static const int kSavedPcSlotFromSp = -1;
-static const int kFirstObjectSlotFromFp = -1; // Used by GC to traverse stack.
+static const int kFirstObjectSlotFromFp = -2; // Used by GC to traverse stack.
static const int kFirstLocalSlotFromFp = -3;
static const int kSavedCallerPpSlotFromFp = -2;
« no previous file with comments | « runtime/vm/stack_frame_arm.h ('k') | runtime/vm/stack_frame_ia32.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698