Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(687)

Unified Diff: runtime/vm/intermediate_language_ia32.cc

Issue 1343373003: Revert "VM: New calling convention for generated code." (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/intermediate_language_arm64.cc ('k') | runtime/vm/intermediate_language_mips.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intermediate_language_ia32.cc
diff --git a/runtime/vm/intermediate_language_ia32.cc b/runtime/vm/intermediate_language_ia32.cc
index 0a53e401b806ba6f8b754f5de0fa15dd0b08aa52..35bc94207177a865a41d0353d22f3282a5155bf6 100644
--- a/runtime/vm/intermediate_language_ia32.cc
+++ b/runtime/vm/intermediate_language_ia32.cc
@@ -6581,22 +6581,20 @@ LocationSummary* IndirectGotoInstr::MakeLocationSummary(Zone* zone,
void IndirectGotoInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
- Register target_reg = locs()->temp_slot(0)->reg();
+ Register target_address_reg = locs()->temp_slot(0)->reg();
- // Load code object from frame.
- __ movl(target_reg, Address(EBP, kPcMarkerSlotFromFp * kWordSize));
- // Load instructions entry point.
- __ movl(target_reg, FieldAddress(target_reg, Code::entry_point_offset()));
+ // Load from [current frame pointer] + kPcMarkerSlotFromFp.
+ __ movl(target_address_reg, Address(EBP, kPcMarkerSlotFromFp * kWordSize));
// Add the offset.
Register offset_reg = locs()->in(0).reg();
if (offset()->definition()->representation() == kTagged) {
__ SmiUntag(offset_reg);
}
- __ addl(target_reg, offset_reg);
+ __ addl(target_address_reg, offset_reg);
// Jump to the absolute address.
- __ jmp(target_reg);
+ __ jmp(target_address_reg);
}
« no previous file with comments | « runtime/vm/intermediate_language_arm64.cc ('k') | runtime/vm/intermediate_language_mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698