Move common identifiers, names and selectors to a separate library.

Move common identifiers, names and selectors to a separate library.

BUG=
R=sigurdm@google.com

Committed: https://github.com/dart-lang/sdk/commit/99bc71afe67d8677a13b843cf42291fc5423819b

[Johnni Winther, 2015-08-20 09:56:26]

johnniwinther@google.com changed reviewers:
+ sigurdm@google.com

[Johnni Winther, 2015-08-20 09:56:27]

Main changes in common/names.dart and compiler.dart.

[sigurdm, 2015-08-20 10:19:02]

LGTM

https://codereview.chromium.org/1299413002/diff/1/pkg/compiler/lib/src/elemen...
File pkg/compiler/lib/src/elements/elements.dart (right):

https://codereview.chromium.org/1299413002/diff/1/pkg/compiler/lib/src/elemen...
pkg/compiler/lib/src/elements/elements.dart:1282: /// The name of this type
declaration taking privacy into account.
 /// The name of this type variable, taking privacy into account.
(insert comma).

https://codereview.chromium.org/1299413002/diff/1/pkg/compiler/lib/src/elemen...
pkg/compiler/lib/src/elements/elements.dart:1494: /// The name of this type
variable taking privacy into account.
Same here

https://codereview.chromium.org/1299413002/diff/1/tests/compiler/dart2js/back...
File tests/compiler/dart2js/backend_dart/dart_backend_test.dart (right):

https://codereview.chromium.org/1299413002/diff/1/tests/compiler/dart2js/back...
tests/compiler/dart2js/backend_dart/dart_backend_test.dart:12: import
'package:compiler/src/compiler.dart' as leg;
This import seems to be unused now.
Would be nice to get rid of references to `leg` - for outsiders it seems really
strange.

[Johnni Winther, 2015-08-20 11:08:22]

Committed patchset #2 (id:20001) manually as
99bc71afe67d8677a13b843cf42291fc5423819b (presubmit successful).

[Johnni Winther, 2015-08-21 11:49:22]

https://codereview.chromium.org/1299413002/diff/1/pkg/compiler/lib/src/elemen...
File pkg/compiler/lib/src/elements/elements.dart (right):

https://codereview.chromium.org/1299413002/diff/1/pkg/compiler/lib/src/elemen...
pkg/compiler/lib/src/elements/elements.dart:1282: /// The name of this type
declaration taking privacy into account.
On 2015/08/20 10:19:02, sigurdm wrote:
>  /// The name of this type variable, taking privacy into account.
> (insert comma).

Done.

https://codereview.chromium.org/1299413002/diff/1/pkg/compiler/lib/src/elemen...
pkg/compiler/lib/src/elements/elements.dart:1494: /// The name of this type
variable taking privacy into account.
On 2015/08/20 10:19:02, sigurdm wrote:
> Same here

Done.

https://codereview.chromium.org/1299413002/diff/1/tests/compiler/dart2js/back...
File tests/compiler/dart2js/backend_dart/dart_backend_test.dart (right):

https://codereview.chromium.org/1299413002/diff/1/tests/compiler/dart2js/back...
tests/compiler/dart2js/backend_dart/dart_backend_test.dart:12: import
'package:compiler/src/compiler.dart' as leg;
On 2015/08/20 10:19:02, sigurdm wrote:
> This import seems to be unused now.
> Would be nice to get rid of references to `leg` - for outsiders it seems
really
> strange.

Removed :)