pkg/compiler/lib/src/js_emitter/class_stub_generator.dart - Issue 1299413002: Move common identifiers, names and selectors to a separate library.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_emitter/class_stub_generator.dart

Issue 1299413002: Move common identifiers, names and selectors to a separate library. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Updated cf. comments. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/compiler/lib/src/js_backend/no_such_method_registry.dart ('k') | pkg/compiler/lib/src/js_emitter/full_emitter/class_emitter.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/compiler/lib/src/js_emitter/class_stub_generator.dart

diff --git a/pkg/compiler/lib/src/js_emitter/class_stub_generator.dart b/pkg/compiler/lib/src/js_emitter/class_stub_generator.dart

index 53e1130fd0538a2f4026607d3bd246d92f067f1a..f29387052d17a93166a80dbf92c084046703ab99 100644

--- a/pkg/compiler/lib/src/js_emitter/class_stub_generator.dart

+++ b/pkg/compiler/lib/src/js_emitter/class_stub_generator.dart

@@ -167,7 +167,7 @@ class ClassStubGenerator {

jsAst.Name methodName = namer.asName(selector.invocationMirrorMemberName);

jsAst.Name internalName = namer.invocationMirrorInternalName(selector);

- assert(backend.isInterceptedName(Compiler.NO_SUCH_METHOD));

+ assert(backend.isInterceptedName(Identifiers.noSuchMethod_));

bool isIntercepted = backend.isInterceptedName(selector.name);

jsAst.Expression expression =

js('''this.#noSuchMethodName(#receiver,