Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Unified Diff: pkg/compiler/lib/src/resolution/resolution.dart

Issue 1299413002: Move common identifiers, names and selectors to a separate library. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Updated cf. comments. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/resolution/members.dart ('k') | pkg/compiler/lib/src/serialization/modelz.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/resolution/resolution.dart
diff --git a/pkg/compiler/lib/src/resolution/resolution.dart b/pkg/compiler/lib/src/resolution/resolution.dart
index 3209c07cbbcdbff3f0ad97d4ffc656bf73075bf2..d10e886e0d8436a20874319b650d0c16002081e4 100644
--- a/pkg/compiler/lib/src/resolution/resolution.dart
+++ b/pkg/compiler/lib/src/resolution/resolution.dart
@@ -6,6 +6,8 @@ library dart2js.resolution;
import 'dart:collection' show Queue;
+import '../common/names.dart' show
+ Identifiers;
import '../common/tasks.dart' show
CompilerTask,
DeferredAction;
@@ -249,7 +251,7 @@ class ResolverTask extends CompilerTask {
// TODO(9631): support noSuchMethod on native classes.
if (Elements.isInstanceMethod(element) &&
- element.name == Compiler.NO_SUCH_METHOD &&
+ element.name == Identifiers.noSuchMethod_ &&
_isNativeClassOrExtendsNativeClass(enclosingClass)) {
error(tree, MessageKind.NO_SUCH_METHOD_IN_NATIVE);
}
@@ -616,7 +618,7 @@ class ResolverTask extends CompilerTask {
}
});
- computeClassMember(element, Compiler.CALL_OPERATOR_NAME);
+ computeClassMember(element, Identifiers.call);
}
void computeClassMembers(ClassElement element) {
« no previous file with comments | « pkg/compiler/lib/src/resolution/members.dart ('k') | pkg/compiler/lib/src/serialization/modelz.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698