Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Unified Diff: pkg/compiler/lib/src/js_backend/backend.dart

Issue 1299413002: Move common identifiers, names and selectors to a separate library. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Updated cf. comments. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_backend/backend.dart
diff --git a/pkg/compiler/lib/src/js_backend/backend.dart b/pkg/compiler/lib/src/js_backend/backend.dart
index 7bf514e811d24da2740e185d7425badc65e3ccfd..b0f9a82df29609e06f49cf76954fd248cbdd26b8 100644
--- a/pkg/compiler/lib/src/js_backend/backend.dart
+++ b/pkg/compiler/lib/src/js_backend/backend.dart
@@ -893,7 +893,7 @@ class JavaScriptBackend extends Backend {
if (enqueuer.isResolutionQueue) {
cls.ensureResolved(compiler);
cls.forEachMember((ClassElement classElement, Element member) {
- if (member.name == Compiler.CALL_OPERATOR_NAME) {
+ if (member.name == Identifiers.call) {
compiler.reportError(
member,
MessageKind.CALL_NOT_SUPPORTED_ON_NATIVE_CLASS);
@@ -1302,7 +1302,7 @@ class JavaScriptBackend extends Backend {
void enableNoSuchMethod(Enqueuer world) {
enqueue(world, getCreateInvocationMirror(), compiler.globalDependencies);
world.registerInvocation(
- new UniverseSelector(compiler.noSuchMethodSelector, null));
+ new UniverseSelector(Selectors.noSuchMethod_, null));
}
void enableIsolateSupport(Enqueuer enqueuer) {
@@ -3054,7 +3054,8 @@ class JavaScriptResolutionCallbacks extends ResolutionCallbacks {
registerBackendStaticInvocation(
backend.getCreateInvocationMirror(), registry);
registerBackendStaticInvocation(
- backend.compiler.objectClass.lookupLocalMember(Compiler.NO_SUCH_METHOD),
+ backend.compiler.objectClass.lookupLocalMember(
+ Identifiers.noSuchMethod_),
registry);
registerBackendInstantiation(backend.compiler.listClass, registry);
registerBackendInstantiation(backend.compiler.stringClass, registry);
« no previous file with comments | « pkg/compiler/lib/src/inferrer/type_graph_nodes.dart ('k') | pkg/compiler/lib/src/js_backend/js_backend.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698