pkg/compiler/lib/src/resolution/class_hierarchy.dart - Issue 1299413002: Move common identifiers, names and selectors to a separate library.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/resolution/class_hierarchy.dart

Issue 1299413002: Move common identifiers, names and selectors to a separate library. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Updated cf. comments. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/compiler/lib/src/js_emitter/runtime_type_generator.dart ('k') | pkg/compiler/lib/src/resolution/class_members.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/compiler/lib/src/resolution/class_hierarchy.dart

diff --git a/pkg/compiler/lib/src/resolution/class_hierarchy.dart b/pkg/compiler/lib/src/resolution/class_hierarchy.dart

index 144dc8eb5295b46996fe0130298cdff65e6bd0b8..a6fb8c4fd98c538a2be78a774076c1c26d91c3cb 100644

--- a/pkg/compiler/lib/src/resolution/class_hierarchy.dart

+++ b/pkg/compiler/lib/src/resolution/class_hierarchy.dart

@@ -201,7 +201,7 @@ class ClassResolverVisitor extends TypeDefinitionVisitor {

registry.registerThrowNoSuchMethod();

} else {

ConstructorElement superConstructor = superMember;

- Selector callToMatch = new Selector.call("", element.library, 0);

+ Selector callToMatch = new Selector.call(const PublicName(''), 0);

superConstructor.computeType(compiler);

if (!callToMatch.applies(superConstructor, compiler.world)) {

MessageKind kind = MessageKind.NO_MATCHING_CONSTRUCTOR_FOR_IMPLICIT;

« no previous file with comments | « pkg/compiler/lib/src/js_emitter/runtime_type_generator.dart ('k') | pkg/compiler/lib/src/resolution/class_members.dart » ('j') | no next file with comments »