Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Side by Side Diff: pkg/compiler/lib/src/elements/elements.dart

Issue 1299413002: Move common identifiers, names and selectors to a separate library. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library elements; 5 library elements;
6 6
7 import '../compiler.dart' show 7 import '../compiler.dart' show
8 Compiler, 8 Compiler,
9 isPrivateName; 9 isPrivateName;
10 import '../constants/constructors.dart'; 10 import '../constants/constructors.dart';
(...skipping 1261 matching lines...) Expand 10 before | Expand all | Expand 10 after
1272 1272
1273 /// JavaScript backend specific element for the body of constructor. 1273 /// JavaScript backend specific element for the body of constructor.
1274 // TODO(johnniwinther): Remove this class from the element model. 1274 // TODO(johnniwinther): Remove this class from the element model.
1275 abstract class ConstructorBodyElement extends MethodElement { 1275 abstract class ConstructorBodyElement extends MethodElement {
1276 FunctionElement get constructor; 1276 FunctionElement get constructor;
1277 } 1277 }
1278 1278
1279 /// [TypeDeclarationElement] defines the common interface for class/interface 1279 /// [TypeDeclarationElement] defines the common interface for class/interface
1280 /// declarations and typedefs. 1280 /// declarations and typedefs.
1281 abstract class TypeDeclarationElement extends Element implements AstElement { 1281 abstract class TypeDeclarationElement extends Element implements AstElement {
1282 /// The name of this type declaration taking privacy into account.
sigurdm 2015/08/20 10:19:02 /// The name of this type variable, taking privacy
Johnni Winther 2015/08/21 11:49:22 Done.
1283 Name get memberName;
1284
1282 /// Do not use [computeType] outside of the resolver; instead retrieve the 1285 /// Do not use [computeType] outside of the resolver; instead retrieve the
1283 /// type from the [thisType] or [rawType], depending on the use case. 1286 /// type from the [thisType] or [rawType], depending on the use case.
1284 /// 1287 ///
1285 /// Trying to access a type that has not been computed in resolution is an 1288 /// Trying to access a type that has not been computed in resolution is an
1286 /// error and calling [computeType] covers that error. 1289 /// error and calling [computeType] covers that error.
1287 /// This method will go away! 1290 /// This method will go away!
1288 @deprecated 1291 @deprecated
1289 GenericType computeType(Compiler compiler); 1292 GenericType computeType(Compiler compiler);
1290 1293
1291 /** 1294 /**
(...skipping 189 matching lines...) Expand 10 before | Expand all | Expand 10 after
1481 // TODO(kasperl): Try to get rid of these. 1484 // TODO(kasperl): Try to get rid of these.
1482 void set isBreakTarget(bool value); 1485 void set isBreakTarget(bool value);
1483 void set isContinueTarget(bool value); 1486 void set isContinueTarget(bool value);
1484 1487
1485 LabelDefinition addLabel(Label label, String labelName); 1488 LabelDefinition addLabel(Label label, String labelName);
1486 } 1489 }
1487 1490
1488 /// The [Element] for a type variable declaration on a generic class or typedef. 1491 /// The [Element] for a type variable declaration on a generic class or typedef.
1489 abstract class TypeVariableElement extends Element 1492 abstract class TypeVariableElement extends Element
1490 implements AstElement, TypedElement { 1493 implements AstElement, TypedElement {
1494 /// The name of this type variable taking privacy into account.
sigurdm 2015/08/20 10:19:02 Same here
Johnni Winther 2015/08/21 11:49:22 Done.
1495 Name get memberName;
1491 1496
1492 /// Use [typeDeclaration] instead. 1497 /// Use [typeDeclaration] instead.
1493 @deprecated 1498 @deprecated
1494 get enclosingElement; 1499 get enclosingElement;
1495 1500
1496 /// The class or typedef on which this type variable is defined. 1501 /// The class or typedef on which this type variable is defined.
1497 TypeDeclarationElement get typeDeclaration; 1502 TypeDeclarationElement get typeDeclaration;
1498 1503
1499 /// The index of this type variable within its type declaration. 1504 /// The index of this type variable within its type declaration.
1500 int get index; 1505 int get index;
(...skipping 151 matching lines...) Expand 10 before | Expand all | Expand 10 after
1652 bool get isDeclaredByField; 1657 bool get isDeclaredByField;
1653 1658
1654 /// Returns `true` if this member is abstract. 1659 /// Returns `true` if this member is abstract.
1655 bool get isAbstract; 1660 bool get isAbstract;
1656 1661
1657 /// If abstract, [implementation] points to the overridden concrete member, 1662 /// If abstract, [implementation] points to the overridden concrete member,
1658 /// if any. Otherwise [implementation] points to the member itself. 1663 /// if any. Otherwise [implementation] points to the member itself.
1659 Member get implementation; 1664 Member get implementation;
1660 } 1665 }
1661 1666
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698