pkg/compiler/lib/src/js_emitter/full_emitter/class_emitter.dart - Issue 1299413002: Move common identifiers, names and selectors to a separate library.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_emitter/full_emitter/class_emitter.dart

Issue 1299413002: Move common identifiers, names and selectors to a separate library. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Updated cf. comments. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/compiler/lib/src/js_emitter/class_stub_generator.dart ('k') | pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/compiler/lib/src/js_emitter/full_emitter/class_emitter.dart

diff --git a/pkg/compiler/lib/src/js_emitter/full_emitter/class_emitter.dart b/pkg/compiler/lib/src/js_emitter/full_emitter/class_emitter.dart

index 10e2792184fc4a1c7e1e8f76a3dbb6415b4c1303..b6b04b8c54f5aa9c62ac20129e7d03d3de4b246d 100644

--- a/pkg/compiler/lib/src/js_emitter/full_emitter/class_emitter.dart

+++ b/pkg/compiler/lib/src/js_emitter/full_emitter/class_emitter.dart

@@ -422,8 +422,10 @@ class ClassEmitter extends CodeEmitterHelper {

ClassBuilder builder,

{bool isGetter}) {

Selector selector = isGetter

- ? new Selector.getter(member.name, member.library)

- : new Selector.setter(member.name, member.library);

+ ? new Selector.getter(

+ new Name(member.name, member.library))

+ : new Selector.setter(

+ new Name(member.name, member.library, isSetter: true));

String reflectionName = emitter.getReflectionName(selector, name);

if (reflectionName != null) {

var reflectable =