Move common identifiers, names and selectors to a separate library.

pkg/compiler/lib/src/js_backend/no_such_method_registry.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of js_backend;
 
 /**
  * Categorizes `noSuchMethod` implementations.
  *
  * If user code includes `noSuchMethod` implementations, type inference is
@@ skipping 86 matching lines @@
           _compiler.reportHint(e,
                                MessageKind.COMPLEX_RETURNING_NSM);
         }
       });
   }
 
   /// Returns [true] if the given element is a complex [noSuchMethod]
   /// implementation. An implementation is complex if it falls into
   /// category C, as described above.
   bool isComplex(FunctionElement element) {
-    assert(element.name == Compiler.NO_SUCH_METHOD);
+    assert(element.name == Identifiers.noSuchMethod_);
     return otherImpls.contains(element);
   }
 
   _subcategorizeOther(FunctionElement element) {
     TypeMask returnType =
         _compiler.typesTask.getGuaranteedReturnTypeOfElement(element);
     if (returnType == const TypeMask.nonNullEmpty()) {
       complexNoReturnImpls.add(element);
     } else {
       complexReturningImpls.add(element);
     }
   }
 
   NsmCategory _categorizeImpl(FunctionElement element) {
-    assert(element.name == Compiler.NO_SUCH_METHOD);
+    assert(element.name == Identifiers.noSuchMethod_);
     if (defaultImpls.contains(element)) {
       return NsmCategory.DEFAULT;
     }
     if (throwingImpls.contains(element)) {
       return NsmCategory.THROWING;
     }
     if (otherImpls.contains(element)) {
       return NsmCategory.OTHER;
     }
-    if (!_compiler.noSuchMethodSelector.signatureApplies(element)) {
+    if (!Selectors.noSuchMethod_.signatureApplies(element)) {
       otherImpls.add(element);
       return NsmCategory.OTHER;
     }
     if (_isDefaultNoSuchMethodImplementation(element)) {
       defaultImpls.add(element);
       return NsmCategory.DEFAULT;
     } else if (_hasForwardingSyntax(element)) {
       // If the implementation is 'noSuchMethod(x) => super.noSuchMethod(x);'
       // then it is in the same category as the super call.
       Element superCall = element.enclosingClass
-          .lookupSuperByName(_compiler.noSuchMethodSelector.memberName);
+          .lookupSuperByName(Selectors.noSuchMethod_.memberName);
       NsmCategory category = _categorizeImpl(superCall);
       switch(category) {
         case NsmCategory.DEFAULT:
           defaultImpls.add(element);
           break;
         case NsmCategory.THROWING:
           throwingImpls.add(element);
           break;
         case NsmCategory.OTHER:
           otherImpls.add(element);
@@ skipping 29 matching lines @@
         !body.statements.isEmpty &&
         body.statements.nodes.tail.isEmpty) {
       Statement stmt = body.statements.nodes.head;
       if (stmt is Return && stmt.hasExpression) {
         expr = stmt.expression;
       }
     }
     if (expr is Send &&
         expr.isSuperCall &&
         expr.selector is Identifier &&
-        (expr.selector as Identifier).source == Compiler.NO_SUCH_METHOD) {
+        (expr.selector as Identifier).source == Identifiers.noSuchMethod_) {
       var arg = expr.arguments.head;
       if (expr.arguments.tail.isEmpty &&
           arg is Send &&
           arg.argumentsNode == null &&
           arg.receiver == null &&
           arg.selector is Identifier &&
           arg.selector.source == param) {
         return true;
       }
     }
@@ skipping 12 matching lines @@
       if (body.statements.nodes.head is ExpressionStatement) {
         ExpressionStatement stmt = body.statements.nodes.head;
         return stmt.expression is Throw;
       }
     }
     return false;
   }
 }
 
 enum NsmCategory { DEFAULT, THROWING, OTHER }