Don't implicitly run "pub get".

Don't implicitly run "pub get".

Previously, several commands automatically ran "pub get" implicitly before doing
their work. We've determined that this behavior is confusing, and for "pub run"
in particular, makes the executables seem much slower than they actually are.

This also allows us to make access to the entrypoint's package graph
synchronous.

R=rnystrom@google.com

Committed: https://github.com/dart-lang/pub/commit/7ae772d834fa08e1f7563d60a2aaebd9e52f28b6

[Bob Nystrom, 2015-08-10 21:54:29]

lgtm

https://codereview.chromium.org/1282533003/diff/1/lib/src/entrypoint.dart
File lib/src/entrypoint.dart (right):

https://codereview.chromium.org/1282533003/diff/1/lib/src/entrypoint.dart#new...
lib/src/entrypoint.dart:54: /// Whether this entrypoing is in memory only, as
opposed to representing a
"entrypoint"

https://codereview.chromium.org/1282533003/diff/1/lib/src/entrypoint.dart#new...
lib/src/entrypoint.dart:64: if (!entryExists(lockFilePath)) {
fileExists()? I suppose it could be a link, but a directory would be bad.

https://codereview.chromium.org/1282533003/diff/1/lib/src/entrypoint.dart#new...
lib/src/entrypoint.dart:354: Set<String> changed) {
Does this fit on the previous line now?

https://codereview.chromium.org/1282533003/diff/1/lib/src/entrypoint.dart#new...
lib/src/entrypoint.dart:415: dataError('No .packages file found, please run "pub
get" first.');
We should definitely figure out how this should be announced with 1.12.

https://codereview.chromium.org/1282533003/diff/1/lib/src/entrypoint.dart#new...
lib/src/entrypoint.dart:418: var packagesMtime = new
File(packagesFile).lastModifiedSync();
"Mtime" is a bit weird (it should at least be "MTime"). How about "Modified"?

https://codereview.chromium.org/1282533003/diff/1/test/test_pub.dart
File test/test_pub.dart (right):

https://codereview.chromium.org/1282533003/diff/1/test/test_pub.dart#newcode513
test/test_pub.dart:513: environment['PUB_HOSTED_URL'] =
"http://localhost:${await port}";
\o/

[nweiz, 2015-08-10 22:32:33]

Code review changes

[nweiz, 2015-08-10 22:32:47]

https://codereview.chromium.org/1282533003/diff/1/lib/src/entrypoint.dart
File lib/src/entrypoint.dart (right):

https://codereview.chromium.org/1282533003/diff/1/lib/src/entrypoint.dart#new...
lib/src/entrypoint.dart:54: /// Whether this entrypoing is in memory only, as
opposed to representing a
On 2015/08/10 21:54:28, Bob Nystrom wrote:
> "entrypoint"

Done.

https://codereview.chromium.org/1282533003/diff/1/lib/src/entrypoint.dart#new...
lib/src/entrypoint.dart:64: if (!entryExists(lockFilePath)) {
On 2015/08/10 21:54:28, Bob Nystrom wrote:
> fileExists()? I suppose it could be a link, but a directory would be bad.

Done.

https://codereview.chromium.org/1282533003/diff/1/lib/src/entrypoint.dart#new...
lib/src/entrypoint.dart:415: dataError('No .packages file found, please run "pub
get" first.');
On 2015/08/10 21:54:28, Bob Nystrom wrote:
> We should definitely figure out how this should be announced with 1.12.

I was planning to send out an email on dart-announce.

https://codereview.chromium.org/1282533003/diff/1/lib/src/entrypoint.dart#new...
lib/src/entrypoint.dart:418: var packagesMtime = new
File(packagesFile).lastModifiedSync();
On 2015/08/10 21:54:28, Bob Nystrom wrote:
> "Mtime" is a bit weird (it should at least be "MTime"). How about "Modified"?

Done.

[nweiz, 2015-08-10 22:33:02]

Committed patchset #2 (id:20001) manually as
7ae772d834fa08e1f7563d60a2aaebd9e52f28b6 (presubmit successful).