Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(565)

Unified Diff: lib/src/dart.dart

Issue 1282533003: Don't implicitly run "pub get". (Closed) Base URL: git@github.com:dart-lang/pub.git@master
Patch Set: Code review changes Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/src/command/list_package_dirs.dart ('k') | lib/src/entrypoint.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/dart.dart
diff --git a/lib/src/dart.dart b/lib/src/dart.dart
index a96e9f69b1f98962bc1d12d8e0f46a919f9b8cbe..4fce3f9ff901663149d5a3872b29278c2f25eec2 100644
--- a/lib/src/dart.dart
+++ b/lib/src/dart.dart
@@ -164,7 +164,8 @@ Future runInIsolate(String code, message, {packageRoot, String snapshot})
log.fine("Spawning isolate from $snapshot.");
if (packageRoot != null) packageRoot = Uri.parse(packageRoot.toString());
try {
- await Isolate.spawnUri(p.toUri(snapshot), [], message,
+ // Make the snapshot URI absolute to work around sdk#8440.
+ await Isolate.spawnUri(p.toUri(p.absolute(snapshot)), [], message,
packageRoot: packageRoot);
return;
} on IsolateSpawnException catch (error) {
@@ -179,7 +180,8 @@ Future runInIsolate(String code, message, {packageRoot, String snapshot})
var port = new ReceivePort();
await Isolate.spawn(_isolateBuffer, {
'replyTo': port.sendPort,
- 'uri': p.toUri(dartPath).toString(),
+ // Make the snapshot URI absolute to work around sdk#8440.
+ 'uri': p.toUri(p.absolute(dartPath)).toString(),
'packageRoot': packageRoot == null ? null : packageRoot.toString(),
'message': message
});
« no previous file with comments | « lib/src/command/list_package_dirs.dart ('k') | lib/src/entrypoint.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698