Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Unified Diff: test/build/outputs_results_to_json_test.dart

Issue 1282533003: Don't implicitly run "pub get". (Closed) Base URL: git@github.com:dart-lang/pub.git@master
Patch Set: Code review changes Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/build/includes_dart_files_in_debug_mode_test.dart ('k') | test/build/preserves_htaccess_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/build/outputs_results_to_json_test.dart
diff --git a/test/build/outputs_results_to_json_test.dart b/test/build/outputs_results_to_json_test.dart
index d20e713af0e71e707f38627c7d70b8ab37a80a13..7c3417fb595b39ad8990de8a43858457cfb37749 100644
--- a/test/build/outputs_results_to_json_test.dart
+++ b/test/build/outputs_results_to_json_test.dart
@@ -20,40 +20,40 @@ main() {
])
]).create();
- schedulePub(args: ["build", "--format", "json"],
- outputJson: {
- 'buildResult': 'success',
- 'outputDirectory': 'build',
- 'numFiles': 1,
- 'log': [
- {
- 'level': 'Info',
- 'transformer': {
- 'name': 'Dart2JS',
- 'primaryInput': {'package': 'myapp', 'path': 'web/main.dart'}
- },
- 'assetId': {'package': 'myapp', 'path': 'web/main.dart'},
- 'message': 'Compiling myapp|web/main.dart...'
- },
- {
- 'level': 'Info',
- 'transformer': {
- 'name': 'Dart2JS',
- 'primaryInput': {'package': 'myapp', 'path': 'web/main.dart'}
- },
- 'assetId': {'package': 'myapp', 'path': 'web/main.dart'},
- 'message': contains(r'to compile myapp|web/main.dart.')
- },
- {
- 'level': 'Fine',
- 'transformer': {
- 'name': 'Dart2JS',
- 'primaryInput': {'package': 'myapp', 'path': 'web/main.dart'}
- },
- 'assetId': {'package': 'myapp', 'path': 'web/main.dart'},
- 'message': contains(r'Took')
- }
- ]
- });
+ pubGet();
+ schedulePub(args: ["build", "--format", "json"], outputJson: {
+ 'buildResult': 'success',
+ 'outputDirectory': 'build',
+ 'numFiles': 1,
+ 'log': [
+ {
+ 'level': 'Info',
+ 'transformer': {
+ 'name': 'Dart2JS',
+ 'primaryInput': {'package': 'myapp', 'path': 'web/main.dart'}
+ },
+ 'assetId': {'package': 'myapp', 'path': 'web/main.dart'},
+ 'message': 'Compiling myapp|web/main.dart...'
+ },
+ {
+ 'level': 'Info',
+ 'transformer': {
+ 'name': 'Dart2JS',
+ 'primaryInput': {'package': 'myapp', 'path': 'web/main.dart'}
+ },
+ 'assetId': {'package': 'myapp', 'path': 'web/main.dart'},
+ 'message': contains(r'to compile myapp|web/main.dart.')
+ },
+ {
+ 'level': 'Fine',
+ 'transformer': {
+ 'name': 'Dart2JS',
+ 'primaryInput': {'package': 'myapp', 'path': 'web/main.dart'}
+ },
+ 'assetId': {'package': 'myapp', 'path': 'web/main.dart'},
+ 'message': contains(r'Took')
+ }
+ ]
+ });
});
}
« no previous file with comments | « test/build/includes_dart_files_in_debug_mode_test.dart ('k') | test/build/preserves_htaccess_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698