test/serve/web_socket/serve_directory_arg_errors_test.dart - Issue 1282533003: Don't implicitly run "pub get".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/serve/web_socket/serve_directory_arg_errors_test.dart

Issue 1282533003: Don't implicitly run "pub get". (Closed) Base URL: git@github.com:dart-lang/pub.git@master

Patch Set: Code review changes Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/serve/web_socket/serve_directory_arg_errors_test.dart

diff --git a/test/serve/web_socket/serve_directory_arg_errors_test.dart b/test/serve/web_socket/serve_directory_arg_errors_test.dart

index 458a5ade024cad48a3eb895ae0f7ce0d504a196b..2f788f9638025a77fdb498a4fd478e4a73729d74 100644

--- a/test/serve/web_socket/serve_directory_arg_errors_test.dart

+++ b/test/serve/web_socket/serve_directory_arg_errors_test.dart

@@ -19,10 +19,11 @@ main() {

d.file("index.html", "<body>")

])

]).create();

+ pubGet();

});

integration("responds with an error if 'path' is not a string", () {

- pubServe(shouldGetFirst: true);

+ pubServe();

expectWebSocketError("serveDirectory", {"path": 123},

rpc_error_code.INVALID_PARAMS,

'Parameter "path" for method "serveDirectory" must be a string, but '

@@ -31,7 +32,7 @@ main() {

});

integration("responds with an error if 'path' is absolute", () {

- pubServe(shouldGetFirst: true);

+ pubServe();

expectWebSocketError("serveDirectory", {"path": "/absolute.txt"},

rpc_error_code.INVALID_PARAMS,

'"path" must be a relative path. Got "/absolute.txt".');

@@ -39,7 +40,7 @@ main() {

});

integration("responds with an error if 'path' reaches out", () {

- pubServe(shouldGetFirst: true);

+ pubServe();

expectWebSocketError("serveDirectory", {"path": "a/../../bad.txt"},

rpc_error_code.INVALID_PARAMS,

'"path" cannot reach out of its containing directory. Got '