Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1077)

Unified Diff: test/dart2js/environment_constant_test.dart

Issue 1282533003: Don't implicitly run "pub get". (Closed) Base URL: git@github.com:dart-lang/pub.git@master
Patch Set: Code review changes Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/dart2js/environment_constant_test.dart
diff --git a/test/dart2js/environment_constant_test.dart b/test/dart2js/environment_constant_test.dart
index 117160655bff8367eee8496ae294117f9e9fc013..81a6ea88951d475a600140e4de362dd7c2bdf3b8 100644
--- a/test/dart2js/environment_constant_test.dart
+++ b/test/dart2js/environment_constant_test.dart
@@ -25,6 +25,7 @@ main() {
});
integration('from "pub build"', () {
+ pubGet();
schedulePub(args: ["build", "--define", "name=fblthp"],
output: new RegExp(r'Built 1 file to "build".'));
@@ -38,7 +39,8 @@ main() {
});
integration('from "pub serve"', () {
- pubServe(args: ["--define", "name=fblthp"], shouldGetFirst: true);
+ pubGet();
+ pubServe(args: ["--define", "name=fblthp"]);
requestShouldSucceed("file.dart.js", contains("fblthp"));
endPubServe();
});
@@ -53,7 +55,8 @@ main() {
})
]).create();
- pubServe(args: ["--define", "name=fblthp"], shouldGetFirst: true);
+ pubGet();
+ pubServe(args: ["--define", "name=fblthp"]);
requestShouldSucceed("file.dart.js", allOf([
contains("fblthp"),
isNot(contains("slartibartfast"))

Powered by Google App Engine
This is Rietveld 408576698