test/dart2js/does_not_compile_until_its_output_is_requested_test.dart - Issue 1282533003: Don't implicitly run "pub get".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/dart2js/does_not_compile_until_its_output_is_requested_test.dart

Issue 1282533003: Don't implicitly run "pub get". (Closed) Base URL: git@github.com:dart-lang/pub.git@master

Patch Set: Code review changes Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « test/dart2js/does_not_compile_if_disabled_test.dart ('k') | test/dart2js/does_not_support_invalid_command_line_options_type_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: test/dart2js/does_not_compile_until_its_output_is_requested_test.dart

diff --git a/test/dart2js/does_not_compile_until_its_output_is_requested_test.dart b/test/dart2js/does_not_compile_until_its_output_is_requested_test.dart

index 448f3c2f6414b0596283b7d4a99c5f73ae3bd989..d89947866c377b94eaa22953d8f31c10ba914fa7 100644

--- a/test/dart2js/does_not_compile_until_its_output_is_requested_test.dart

+++ b/test/dart2js/does_not_compile_until_its_output_is_requested_test.dart

@@ -20,7 +20,8 @@ main() {

])

]).create();

- var server = pubServe(shouldGetFirst: true);

+ pubGet();

+ var server = pubServe();

server.stdout.expect("Build completed successfully");

// Once we request the output, it should start compiling and fail.