Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Unified Diff: test/serve/utils.dart

Issue 1282533003: Don't implicitly run "pub get". (Closed) Base URL: git@github.com:dart-lang/pub.git@master
Patch Set: Code review changes Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/serve/uses_appropriate_mime_types_test.dart ('k') | test/serve/watch_added_file_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/serve/utils.dart
diff --git a/test/serve/utils.dart b/test/serve/utils.dart
index 83b691c1b0e513bb1ff618432225d6a0425ebdfa..3862df72ba216107adc11544b0e1a794e1f21b3c 100644
--- a/test/serve/utils.dart
+++ b/test/serve/utils.dart
@@ -168,14 +168,11 @@ ScheduledProcess startPubServe({Iterable<String> args,
/// Schedules starting the "pub serve" process and records its port number for
/// future requests.
///
-/// If [shouldGetFirst] is `true`, validates that pub get is run first.
-///
/// If [createWebDir] is `true`, creates a `web/` directory if one doesn't exist
/// so pub doesn't complain about having nothing to serve.
///
/// Returns the `pub serve` process.
-ScheduledProcess pubServe({bool shouldGetFirst: false, bool createWebDir: true,
- Iterable<String> args}) {
+ScheduledProcess pubServe({bool createWebDir: true, Iterable<String> args}) {
_pubServer = startPubServe(args: args, createWebDir: createWebDir);
_portsCompleter = new Completer();
@@ -190,13 +187,6 @@ ScheduledProcess pubServe({bool shouldGetFirst: false, bool createWebDir: true,
}
});
- if (shouldGetFirst) {
- _pubServer.stdout.expect(consumeThrough(anyOf([
- "Got dependencies!",
- matches(new RegExp(r"^Changed \d+ dependenc"))
- ])));
- }
-
_pubServer.stdout.expect(startsWith("Loading source assets..."));
_pubServer.stdout.expect(consumeWhile(matches("Loading .* transformers...")));
« no previous file with comments | « test/serve/uses_appropriate_mime_types_test.dart ('k') | test/serve/watch_added_file_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698