Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Side by Side Diff: test/serve/404_page_test.dart

Issue 1282533003: Don't implicitly run "pub get". (Closed) Base URL: git@github.com:dart-lang/pub.git@master
Patch Set: Code review changes Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS d.file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS d.file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library pub_tests; 5 library pub_tests;
6 6
7 import 'package:scheduled_test/scheduled_test.dart'; 7 import 'package:scheduled_test/scheduled_test.dart';
8 8
9 import '../descriptor.dart' as d; 9 import '../descriptor.dart' as d;
10 import '../test_pub.dart'; 10 import '../test_pub.dart';
11 import 'utils.dart'; 11 import 'utils.dart';
12 12
13 main() { 13 main() {
14 setUp(() { 14 setUp(() {
15 d.dir(appPath, [ 15 d.dir(appPath, [
16 d.appPubspec() 16 d.appPubspec()
17 ]).create(); 17 ]).create();
18 }); 18 });
19 19
20 integration("the 404 page describes the missing asset", () { 20 integration("the 404 page describes the missing asset", () {
21 pubServe(shouldGetFirst: true); 21 pubGet();
22 pubServe();
22 23
23 scheduleRequest("packages/foo/missing.txt").then((response) { 24 scheduleRequest("packages/foo/missing.txt").then((response) {
24 expect(response.statusCode, equals(404)); 25 expect(response.statusCode, equals(404));
25 26
26 // Should mention the asset that can't be found. 27 // Should mention the asset that can't be found.
27 expect(response.body, contains("foo")); 28 expect(response.body, contains("foo"));
28 expect(response.body, contains("missing.txt")); 29 expect(response.body, contains("missing.txt"));
29 }); 30 });
30 31
31 endPubServe(); 32 endPubServe();
32 }); 33 });
33 34
34 integration("the 404 page describes the error", () { 35 integration("the 404 page describes the error", () {
35 pubServe(shouldGetFirst: true); 36 pubGet();
37 pubServe();
36 38
37 scheduleRequest("packages").then((response) { 39 scheduleRequest("packages").then((response) {
38 expect(response.statusCode, equals(404)); 40 expect(response.statusCode, equals(404));
39 41
40 // Should mention the asset that can't be found. 42 // Should mention the asset that can't be found.
41 expect(response.body, contains('"/packages"')); 43 expect(response.body, contains('"/packages"'));
42 }); 44 });
43 45
44 endPubServe(); 46 endPubServe();
45 }); 47 });
46 } 48 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698