Rename 'dart:debugger' to 'dart:developer'

Rename 'dart:debugger' to 'dart:developer'

- Rename 'dart:debugger' to 'dart:developer'
- Make 'breakHere' and 'breakHereIf' top level functions.

R=iposva@google.com

Committed: https://code.google.com/p/dart/source/detail?r=45658

[Cutch, 2015-05-08 15:03:54]

johnmccutchan@google.com changed reviewers:
+ alanknight@google.com, lrn@google.com

[Cutch, 2015-05-08 20:01:54]

johnmccutchan@google.com changed reviewers:
+ iposva@google.com
- alanknight@google.com, lrn@google.com

[Ivan Posva, 2015-05-08 20:45:04]

LGTM

Rietveld is not a great tool for naming discussion, so we can take that part
offline.

-Ivan

https://codereview.chromium.org/1132113002/diff/40001/runtime/lib/developer.cc
File runtime/lib/developer.cc (right):

https://codereview.chromium.org/1132113002/diff/40001/runtime/lib/developer.c...
runtime/lib/developer.cc:17: // dart:debugger.
Can you please expand on this comment?

https://codereview.chromium.org/1132113002/diff/40001/runtime/lib/developer.dart
File runtime/lib/developer.dart (right):

https://codereview.chromium.org/1132113002/diff/40001/runtime/lib/developer.d...
runtime/lib/developer.dart:5: import 'dart:_internal';
Why this import?

https://codereview.chromium.org/1132113002/diff/40001/runtime/lib/developer.d...
runtime/lib/developer.dart:8: patch void breakHereIf(bool expr) native
"Debugger_breakHereIf";
breakHere({bool if: true, String msg});

Also the name feels awkward to me as it does not mention anything about the
debugger. "break" is an entirely different concept in the language.

[Cutch, 2015-05-08 21:22:37]

https://codereview.chromium.org/1132113002/diff/40001/runtime/lib/developer.cc
File runtime/lib/developer.cc (right):

https://codereview.chromium.org/1132113002/diff/40001/runtime/lib/developer.c...
runtime/lib/developer.cc:17: // dart:debugger.
On 2015/05/08 20:45:04, Ivan Posva wrote:
> Can you please expand on this comment?

Done.

https://codereview.chromium.org/1132113002/diff/40001/runtime/lib/developer.dart
File runtime/lib/developer.dart (right):

https://codereview.chromium.org/1132113002/diff/40001/runtime/lib/developer.d...
runtime/lib/developer.dart:5: import 'dart:_internal';
On 2015/05/08 20:45:04, Ivan Posva wrote:
> Why this import?

Done.

https://codereview.chromium.org/1132113002/diff/40001/runtime/lib/developer.d...
runtime/lib/developer.dart:8: patch void breakHereIf(bool expr) native
"Debugger_breakHereIf";
On 2015/05/08 20:45:04, Ivan Posva wrote:
> breakHere({bool if: true, String msg});
> 
> Also the name feels awkward to me as it does not mention anything about the
> debugger. "break" is an entirely different concept in the language.

went with 'debugger({bool when: true, String msg})'

[Cutch, 2015-05-08 21:25:23]

Committed patchset #4 (id:60001) manually as 45658 (presubmit successful).

[Ivan Posva, 2015-05-08 21:56:12]

-ip

https://codereview.chromium.org/1132113002/diff/60001/runtime/vm/bootstrap_na...
File runtime/vm/bootstrap_natives.h (right):

https://codereview.chromium.org/1132113002/diff/60001/runtime/vm/bootstrap_na...
runtime/vm/bootstrap_natives.h:90: V(Developer_debugger, 2)                     
                               \
o before e?