Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(585)

Unified Diff: runtime/vm/debugger.cc

Issue 1132113002: Rename 'dart:debugger' to 'dart:developer' (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/debugger.cc
diff --git a/runtime/vm/debugger.cc b/runtime/vm/debugger.cc
index a33a3047b56ef264afea29f564ebed5bd11d5b6f..4650eacc5be46db9676e8f9ab27ebfb038833fa2 100644
--- a/runtime/vm/debugger.cc
+++ b/runtime/vm/debugger.cc
@@ -2275,7 +2275,7 @@ void Debugger::SignalBpReached() {
}
-void Debugger::BreakHere() {
+void Debugger::BreakHere(const String& msg) {
// We ignore this breakpoint when the VM is executing code invoked
// by the debugger to evaluate variables values, or when we see a nested
// breakpoint or exception event.
@@ -2288,6 +2288,8 @@ void Debugger::BreakHere() {
ASSERT(stack_trace_ == NULL);
stack_trace_ = stack_trace;
+ // TODO(johnmccutchan): Send |msg| to Observatory.
+
// We are in the native call to Debugger_breakHere or Debugger_breakHereIf,
// the developer gets a better experience by not seeing this call. To
// accomplish this, we continue execution until the call exits (step out).
« runtime/vm/bootstrap_natives.h ('K') | « runtime/vm/debugger.h ('k') | runtime/vm/object.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698