Change IllegalArgumentException to ArgumentError.

Change IllegalArgumentException to ArgumentError.

Committed: https://code.google.com/p/dart/source/detail?r=12841

[Lasse Reichstein Nielsen, 2012-09-25 10:59:42]

Still working on the analyzer test expectation. Please review what's here.

The real change is in lib/core/{errors,exceptions}.dart, most of the rest is
just search/replace.

[Lasse Reichstein Nielsen, 2012-09-25 11:07:13]

Adding Mads too.

[Lasse Reichstein Nielsen, 2012-09-25 11:27:05]

Analyzer tests are fine as-is.

[Søren Gjesse, 2012-09-25 12:22:24]

lgtm

https://codereview.chromium.org/10989013/diff/2001/lib/core/errors.dart
File lib/core/errors.dart (right):

https://codereview.chromium.org/10989013/diff/2001/lib/core/errors.dart#newco...
lib/core/errors.dart:28: String toString() => "Illegal argument(s): $message";
Shouldn't the toString result be without the ": " at the end if message is null
or the empty string?

https://codereview.chromium.org/10989013/diff/2001/tests/co19/co19-dart2js.st...
File tests/co19/co19-dart2js.status (right):

https://codereview.chromium.org/10989013/diff/2001/tests/co19/co19-dart2js.st...
tests/co19/co19-dart2js.status:96:
LibTest/core/Completer/completeException_A02_t01: Fail # issue 224
Please add co19 to the comment to avoid confusion with the dart issue numbers.

[Lasse Reichstein Nielsen, 2012-09-25 12:28:07]

I have made changes to dart2js_html. The next time it's generated, it'll need to
use ArgumentError instead of IllegalArgumentException.

https://codereview.chromium.org/10989013/diff/2001/lib/core/errors.dart
File lib/core/errors.dart (right):

https://codereview.chromium.org/10989013/diff/2001/lib/core/errors.dart#newco...
lib/core/errors.dart:28: String toString() => "Illegal argument(s): $message";
It should, yes.

https://codereview.chromium.org/10989013/diff/2001/tests/co19/co19-dart2js.st...
File tests/co19/co19-dart2js.status (right):

https://codereview.chromium.org/10989013/diff/2001/tests/co19/co19-dart2js.st...
tests/co19/co19-dart2js.status:96:
LibTest/core/Completer/completeException_A02_t01: Fail # issue 224
On 2012/09/25 12:22:24, Søren Gjesse wrote:
> Please add co19 to the comment to avoid confusion with the dart issue numbers.

Done.