Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(496)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: runtime/lib/integers.cc

Issue 10989013: Change IllegalArgumentException to ArgumentError. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Updated co19 test expectations. Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« lib/core/errors.dart ('K') | « runtime/lib/growable_array.dart ('k') | runtime/lib/integers.dart » ('j') | tests/co19/co19-dart2js.status » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/lib/integers.cc
diff --git a/runtime/lib/integers.cc b/runtime/lib/integers.cc
index 7bb041e8089140d78068dd8ae106d85600fbe1a9..d831c1650ffeba1db597eac7a3a70186a89d549b 100644
--- a/runtime/lib/integers.cc
+++ b/runtime/lib/integers.cc
@@ -178,7 +178,7 @@ static RawInteger* ShiftOperationHelper(Token::Kind kind,
if (amount.Value() < 0) {
GrowableArray<const Object*> args;
args.Add(&amount);
- Exceptions::ThrowByType(Exceptions::kIllegalArgument, args);
+ Exceptions::ThrowByType(Exceptions::kArgument, args);
}
if (value.IsSmi()) {
Smi& smi_value = Smi::Handle();
« lib/core/errors.dart ('K') | « runtime/lib/growable_array.dart ('k') | runtime/lib/integers.dart » ('j') | tests/co19/co19-dart2js.status » ('J')

Powered by Google App Engine
This is Rietveld 408576698