Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: runtime/bin/dartutils.cc

Issue 10989013: Change IllegalArgumentException to ArgumentError. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Updated co19 test expectations. Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« lib/core/errors.dart ('K') | « pkg/unittest/test/matchers_test.dart ('k') | runtime/bin/directory_impl.dart » ('j') | tests/co19/co19-dart2js.status » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/dartutils.cc
diff --git a/runtime/bin/dartutils.cc b/runtime/bin/dartutils.cc
index 33e4a540177701966e9f6f47e63cc52d9e9a8fa8..35dadfc87b322bc90820b131831061864e9e3fcf 100644
--- a/runtime/bin/dartutils.cc
+++ b/runtime/bin/dartutils.cc
@@ -634,14 +634,14 @@ Dart_CObject* CObject::NewExternalUint8Array(int length,
}
-static int kIllegalArgumentError = 1;
+static int kArgumentError = 1;
static int kOSError = 2;
static int kFileClosedError = 3;
CObject* CObject::IllegalArgumentError() {
CObjectArray* result = new CObjectArray(CObject::NewArray(1));
- result->SetAt(0, new CObjectInt32(CObject::NewInt32(kIllegalArgumentError)));
+ result->SetAt(0, new CObjectInt32(CObject::NewInt32(kArgumentError)));
return result;
}
« lib/core/errors.dart ('K') | « pkg/unittest/test/matchers_test.dart ('k') | runtime/bin/directory_impl.dart » ('j') | tests/co19/co19-dart2js.status » ('J')

Powered by Google App Engine
This is Rietveld 408576698