Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: runtime/bin/socket_impl.dart

Issue 10989013: Change IllegalArgumentException to ArgumentError. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Updated co19 test expectations. Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« lib/core/errors.dart ('K') | « runtime/bin/process_impl.dart ('k') | runtime/bin/websocket_impl.dart » ('j') | tests/co19/co19-dart2js.status » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/socket_impl.dart
diff --git a/runtime/bin/socket_impl.dart b/runtime/bin/socket_impl.dart
index b0099e505fd5ba469d2e905eb6d9f0e12dca54d2..49654130d1132e1aeac09c08c10343097025d226 100644
--- a/runtime/bin/socket_impl.dart
+++ b/runtime/bin/socket_impl.dart
@@ -208,7 +208,7 @@ class _SocketBase extends NativeFieldWrapperClass1 {
assert(_isErrorResponse(error));
switch (error[0]) {
case _FileUtils.ILLEGAL_ARGUMENT_RESPONSE:
- doReportError(new IllegalArgumentException());
+ doReportError(new ArgumentError());
break;
case _FileUtils.OSERROR_RESPONSE:
doReportError(new SocketIOException(
« lib/core/errors.dart ('K') | « runtime/bin/process_impl.dart ('k') | runtime/bin/websocket_impl.dart » ('j') | tests/co19/co19-dart2js.status » ('J')

Powered by Google App Engine
This is Rietveld 408576698