Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1651)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: pkg/fixnum/int32.dart

Issue 10989013: Change IllegalArgumentException to ArgumentError. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Updated co19 test expectations. Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« lib/core/errors.dart ('K') | « pkg/dartdoc/lib/src/mirrors/dart2js_mirror.dart ('k') | pkg/fixnum/int64.dart » ('j') | tests/co19/co19-dart2js.status » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/fixnum/int32.dart
diff --git a/pkg/fixnum/int32.dart b/pkg/fixnum/int32.dart
index 6638179aa3330f98bf8d183dd91da461128fb008..3787dc89052261f33f6bb35877d7fe7e4591763e 100644
--- a/pkg/fixnum/int32.dart
+++ b/pkg/fixnum/int32.dart
@@ -238,7 +238,7 @@ class int32 implements intx {
int32 operator <<(int n) {
if (n < 0) {
- throw new IllegalArgumentException("$n");
+ throw new ArgumentError("$n");
}
n &= 31;
return new int32.fromInt(_i << n);
@@ -246,7 +246,7 @@ class int32 implements intx {
int32 operator >>(int n) {
if (n < 0) {
- throw new IllegalArgumentException("$n");
+ throw new ArgumentError("$n");
}
n &= 31;
int value;
@@ -260,7 +260,7 @@ class int32 implements intx {
int32 shiftRightUnsigned(int n) {
if (n < 0) {
- throw new IllegalArgumentException("$n");
+ throw new ArgumentError("$n");
}
n &= 31;
int value;
« lib/core/errors.dart ('K') | « pkg/dartdoc/lib/src/mirrors/dart2js_mirror.dart ('k') | pkg/fixnum/int64.dart » ('j') | tests/co19/co19-dart2js.status » ('J')

Powered by Google App Engine
This is Rietveld 408576698