Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: runtime/bin/websocket_impl.dart

Issue 10989013: Change IllegalArgumentException to ArgumentError. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Updated co19 test expectations. Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« lib/core/errors.dart ('K') | « runtime/bin/socket_impl.dart ('k') | runtime/lib/array.cc » ('j') | tests/co19/co19-dart2js.status » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/websocket_impl.dart
diff --git a/runtime/bin/websocket_impl.dart b/runtime/bin/websocket_impl.dart
index 27fad8168b06552888e7b028a9a2b54e38998421..4311e11adf318901e42e9c0e59970b6ab2e276db 100644
--- a/runtime/bin/websocket_impl.dart
+++ b/runtime/bin/websocket_impl.dart
@@ -414,7 +414,7 @@ class _WebSocketConnectionBase {
data = _StringEncoders.encoder(Encoding.UTF_8).encodeString(message);
} else {
if (message is !List<int>) {
- throw new IllegalArgumentException(message);
+ throw new ArgumentError(message);
}
opcode = _WebSocketOpcode.BINARY;
data = message;
« lib/core/errors.dart ('K') | « runtime/bin/socket_impl.dart ('k') | runtime/lib/array.cc » ('j') | tests/co19/co19-dart2js.status » ('J')

Powered by Google App Engine
This is Rietveld 408576698